| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
LGTM. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @hugovk for commit 2281499 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149195%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Co-authored-by: Dino Viehland <dinoviehland@meta.com> Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
|
@zanieb @nascheme Could you please take another look? I've ported the 3.14 heap_size changes and included heap_size in get_gc_stats. @DinoV FYI, the layout of _gc_runtime_state will change since we moved generation_stats to the heap. |
Sorry, something went wrong.
|
I'd say for 3.15 we don't need the two dummy members and we could move generation0 back to it's old position. Preserving the member offsets should not be required for 3.15, right? |
Sorry, something went wrong.
|
Since we're moving the stats to the heap, all subsequent offsets will shift anyway. There's no need to keep the dummy members. I thought this would simplify backports if needed. I'm happy to remove the dummy members and restore generation0 if you think that's cleaner. |
Sorry, something went wrong.
I think it's better to remove the dummy members. You don't have to restore generation0 since the code looks fine without that member. Other than that, this PR looks fine to me. |
Sorry, something went wrong.
…ov/cpython into feat/gc-gen-3.15+heap_size
There was a problem hiding this comment.
Great job @sergey-miryanov
Sorry, something went wrong.
|
Thanks all! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.