FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-149225: Expose Py_CriticalSection in Stable ABI by encukou · Pull Request #149227 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-149225: Expose Py_CriticalSection in Stable ABI - #149227

Merged
encukou merged 7 commits into
python:mainfrom
encukou:critical-section-stable-abi-xs
May 4, 2026
ConversationCommits (7)ChecksFiles changed
Merged

gh-149225: Expose Py_CriticalSection in Stable ABI#149227
encukou merged 7 commits into
python:mainfrom
encukou:critical-section-stable-abi-xs

Conversation

encukou commented May 1, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

encukou requested review from a team and ZeroIntensity as code owners May 1, 2026 12:47
bedevere-app Bot mentioned this pull request May 1, 2026
Closed

read-the-docs-community Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32528039 | 📁 Comparing b289183 against main (f2c7c0d)

  🔍 Preview build  

43 files changed · ± 43 modified

± Modified

corona10 reviewed May 1, 2026
View reviewed changes
Comment thread Doc/c-api/synchronization.rst
hugovk added the 3.15 bugs and security fixes label May 1, 2026
vstinner approved these changes May 2, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Include/critical_section.h Outdated
// Operations that need to lock two objects at once must use
// `Py_BEGIN_CRITICAL_SECTION2()`. You *CANNOT* use nested critical sections
// to lock more than one object at once, because the inner critical section
// may suspend the outer critical sections. This API does not provide a way

vstinner May 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// may suspend the outer critical sections. This API does not provide a way
// may suspend the outer critical sections. This API does not provide a way

Comment thread Misc/NEWS.d/next/C_API/2026-05-01-14-49-09.gh-issue-149225.IdAYPZ.rst
@@ -0,0 +1,2 @@
:c:type:`PyCriticalSection` and related functions are added to the Stable
ABI.

vstinner May 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you copy also this paragraph to What's New in Python 3.15 > C API changes > New features?

Comment thread Doc/c-api/synchronization.rst
encukou requested a review from AA-Turner as a code owner May 4, 2026 12:53

vstinner commented May 4, 2026

Copy link
Copy Markdown
Member

Tests / Windows / Build and test (x64, switch-case) (pull_request): Failing after 23m

Oh, the "FAIL: test_got_eof (test.test_ssl.ThreadedTests.test_got_eof)" failure is related to my recent OpenSSL 4 changes. I wrote #149366 to fix the test.

encukou merged commit 6ca5cdb into python:main May 4, 2026
98 of 102 checks passed
encukou deleted the critical-section-stable-abi-xs branch May 4, 2026 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 left review comments
vstinner vstinner approved these changes
ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

3.15 bugs and security fixes release-blocker

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL