Repository navigation
gh-145378: Generate consistent colors for pdb commands - #149305
gaogaotiantian merged 4 commits into
Conversation
Sorry, something went wrong.
Documentation build overview5 files changed · ± 5 modified ± Modified |
Sorry, something went wrong.
| return None | ||
|
|
||
| def gen_colors(self, buffer): | ||
| from _pyrepl.utils import ColorSpan, Span |
There was a problem hiding this comment.
Just nit comment, now we can use lazy import right?
Sorry, something went wrong.
Sorry, something went wrong.
There was a problem hiding this comment.
This instance itself is protected by a check for the existence of _pyrepl (_pyrepl_available). If this instance is created, then _pyrepl must exist. Having these _pyrepl related imports inside the method saves us the trouble to deal with the cases where _pyrepl does not exist. If the same class is used multiple times, lazy import might be a better options. I hope that makes sense?
Sorry, something went wrong.
corona10
left a comment
There was a problem hiding this comment.
overall lgtm
Sorry, something went wrong.
We supported pyrepl for pdb input. We used the default pyrepl color scheme which works most of the time. However, for pdb commands, they are not recognized. There are also some pdb commands (list, continue) that would be recognized as different things in pyrepl.
We should recognize those commands and use a consistent color for it. It's actually pretty helpful because users will (probably) realize that a = 1 won't work because a has a special color (a is a command for arg).