FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py by skirpichev · Pull Request #149345 · python/cpython · GitHub

/ cpython Public

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py - #149345

Merged
vstinner merged 9 commits into
python:mainfrom
skirpichev:amend-e-format
May 6, 2026
ConversationCommits (9)ChecksFiles changed
Merged

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py#149345
vstinner merged 9 commits into
python:mainfrom
skirpichev:amend-e-format

Conversation

skirpichev commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

pythongh-146238: add missing tests for 'e' type code in test_buffer.py
d00c981 
This amends e79fd60.  I'll not fix this for 'F'/'D' complex types as
they might be removed.
bedevere-app Bot added the tests Tests in the Lib/test dir label May 4, 2026
bedevere-app Bot mentioned this pull request May 4, 2026
Closed
skirpichev closed this May 4, 2026
skirpichev deleted the amend-e-format branch May 4, 2026 15:25
skirpichev restored the amend-e-format branch May 5, 2026 02:01
skirpichev reopened this May 5, 2026
skirpichev changed the title gh-146238: add missing tests for 'e' type code in test_buffer.py gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py May 5, 2026
skirpichev requested a review from vstinner May 5, 2026 02:27

skirpichev commented May 5, 2026

Copy link
Copy Markdown
Member Author

CC @vstinner

This comment was marked as resolved.

Sign in to view

This comment was marked as spam.

Sign in to view
vstinner reviewed May 5, 2026
View reviewed changes
Comment thread Lib/test/test_buffer.py Outdated
Comment thread Lib/test/test_buffer.py Outdated
Comment thread Lib/test/test_buffer.py

This comment was marked as resolved.

Sign in to view

vstinner commented May 5, 2026

Copy link
Copy Markdown
Member

On WASI, ALIGNOF_MAX_ALIGN_T is 16 bytes and struct.calcsize("Zd") is 16 bytes. WASI is a 32-bit platform (sys.maxsize is 2147483647). Maybe we should only test formats up to 4 bytes?

Would it make sense to use MAX_ALIGN = struct.calcsize('P')?

skirpichev commented May 6, 2026

Copy link
Copy Markdown
Member Author

Would it make sense to use MAX_ALIGN = struct.calcsize('P')?

As you see from the commit history, just removing the 'Zd' type - works. But I would like to use a more generic solution.

vstinner merged commit ffa4d47 into python:main May 6, 2026
49 checks passed

vstinner commented May 6, 2026

Copy link
Copy Markdown
Member

I prefer a small performance hit for readability.

I would prefer to not build list("bBhHiIlLefd") + ['Zf', 'Zd'] list at each NATIVE iteration, but it's not a big deal. I merged your PR. Thanks for additional tests.

skirpichev deleted the amend-e-format branch May 6, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL