FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-149358: Generating JIT recorder transformers and stabilizing family layouts by cocolato · Pull Request #149359 · python/cpython · GitHub

/ cpython Public

gh-149358: Generating JIT recorder transformers and stabilizing family layouts - #149359

Merged
markshannon merged 8 commits into
python:mainfrom
cocolato:jit_record_family
May 21, 2026
ConversationCommits (8)ChecksFiles changed
Merged

gh-149358: Generating JIT recorder transformers and stabilizing family layouts#149359
markshannon merged 8 commits into
python:mainfrom
cocolato:jit_record_family

Conversation

cocolato commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request May 4, 2026
Closed

read-the-docs-community Bot commented May 4, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32525708 | 📁 Comparing 5617cec against main (2ba0a81)

  🔍 Preview build  

3 files changed
± library/calendar.html
± whatsnew/3.15.html
± whatsnew/changelog.html

cocolato mentioned this pull request May 4, 2026
Merged
markshannon requested changes May 19, 2026
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could do with a couple more tests, but looks good otherwise

Comment thread Lib/test/test_generated_cases.py
op(_DO_STUFF, (tos -- res)) {
res = tos;
}
macro(OP) = _RECORD_TOS + _DO_STUFF;

markshannon May 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add tests for:

  • Base op does not record, but specialization does
  • Base op does record, but specialization does not

Comment thread Tools/cases_generator/analyzer.py Outdated
size: str
members: list[Instruction]

@property

markshannon May 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you make this a normal function? It is quite heavyweight for a property

bedevere-app Bot commented May 19, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

cocolato commented May 20, 2026

Copy link
Copy Markdown
Member Author

Thanks for review ! I have made the requested changes; please review again.

bedevere-app Bot commented May 20, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

bedevere-app Bot requested a review from markshannon May 20, 2026 10:09
markshannon approved these changes May 21, 2026
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thanks.

markshannon merged commit 0828782 into python:main May 21, 2026
84 of 87 checks passed
cocolato deleted the jit_record_family branch May 23, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes
Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL