gh-100239: specialize mixed int/float inplace binary ops - #149413
Merged
markshannon merged 1 commit intoMay 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Author
|
Should I request @markshannon review? Thank you! |
Sorry, something went wrong.
markshannon
self-requested a review
May 5, 2026 13:42
markshannon
approved these changes
May 5, 2026
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice, simple change.
Looks good to me.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Nice! If performance matters for this case, we can also add tier2 ops that use inplace operations in case the float is uniquely referenced. (for a followup PR though) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.