FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-149202: Don't use -fno-omit-frame-pointer on ppc64le by vstinner · Pull Request #149485 · python/cpython · GitHub

/ cpython Public

gh-149202: Don't use -fno-omit-frame-pointer on ppc64le - #149485

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:ppc64le
May 7, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-149202: Don't use -fno-omit-frame-pointer on ppc64le#149485
vstinner merged 1 commit into
python:mainfrom
vstinner:ppc64le

Conversation

vstinner commented May 7, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The power ABI specification requires that compilers maintain a back chain by default, so unwinding already works without a dedicated frame pointer. Don't use -fno-omit-frame-pointer on ppc64le.

pythongh-149202: Don't use -fno-omit-frame-pointer on ppc64le
ea140bb 
The power ABI specification requires that compilers maintain a back
chain by default, so unwinding already works without a dedicated
frame pointer. Don't use -fno-omit-frame-pointer on ppc64le.
bedevere-app Bot mentioned this pull request May 7, 2026
Closed

read-the-docs-community Bot commented May 7, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32580775 | 📁 Comparing ea140bb against main (612140e)

  🔍 Preview build  

1 file changed
± using/configure.html

vstinner commented May 7, 2026

Copy link
Copy Markdown
Member Author

This PR implements @stratakis' suggestions: #149409 (comment). Extract:

Adding however -fno-omit-frame-pointer forces the compiler to reserve r31 for it adding extra overhead with no benefits.

cc @stratakis @encukou @pablogsal @Fidget-Spinner @savannahostrowski

vstinner mentioned this pull request May 7, 2026
Merged

vstinner commented May 7, 2026

Copy link
Copy Markdown
Member Author

I tested this change manually on Linux ppc64le:

  • ./configure (gcc -O3): OPT=-DNDEBUG -g -O3 -Wall in Makefile
  • ./configure --with-pydebug (gcc -Og): OPT=-g -Og -Wall in Makefile

test_frame_pointer_unwind pass successfully.

pablogsal commented May 7, 2026

Copy link
Copy Markdown
Member

Thanks Victor!

vstinner commented May 7, 2026

Copy link
Copy Markdown
Member Author

!buildbot PPC64LE

bedevere-bot commented May 7, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit ea140bb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149485%2Fmerge

The command will test the builders whose names match following regular expression: PPC64LE

The builders matched are:

  • PPC64LE Fedora Rawhide Clang PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE RHEL8 LTO + PGO PR
  • PPC64LE Fedora Stable Clang PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide PR
  • PPC64LE CentOS9 LTO PR
  • PPC64LE Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Stable Refleaks PR
  • PPC64LE Fedora Rawhide LTO PR
  • PPC64LE Fedora Stable PR
  • PPC64LE Fedora Stable LTO + PGO PR
  • PPC64LE CentOS9 LTO + PGO PR
  • PPC64LE Fedora Stable LTO PR
  • PPC64LE Fedora Rawhide NoGIL PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • PPC64LE Fedora Stable Clang Installed PR
  • PPC64LE Fedora Rawhide LTO + PGO PR
  • PPC64LE CentOS9 PR
  • PPC64LE RHEL8 LTO PR
  • PPC64LE RHEL8 PR
  • PPC64LE CentOS9 Refleaks PR

vstinner merged commit b3cfd36 into python:main May 7, 2026
65 of 78 checks passed
vstinner deleted the ppc64le branch May 7, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL