gh-149313: Preserve exception notes/cause in dict/set unhashable type… - #149505
Open
anujbharambe wants to merge 2 commits into
Open
gh-149313: Preserve exception notes/cause in dict/set unhashable type…#149505anujbharambe wants to merge 2 commits into
anujbharambe wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anujbharambe
requested review from
markshannon,
methane and
rhettinger
as code owners
May 7, 2026 17:45
Copy link
Copy Markdown
Member
|
Updating to fix some errors we introduced on the main branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 90 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chain the original TypeError as __cause__ and __context__ on the new exception in dict_unhashable_type() and set_unhashable_type(). This preserves __notes__, __traceback__, and any existing cause chain that were previously discarded when the improved error message was created.
Fixes #149313
Some parts of this PR were written with the assistance of Claude (AI).