Repository navigation
gh-149504: Fix reentrant site startup processing - #149516
Closed
zsol wants to merge 2 commits into
Closed
zsol wants to merge 2 commits into
zsol wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy and clear pending startup file data before executing import lines or .start entry points so recursive site.addsitedir() calls process a separate batch.
Copy link
Copy Markdown
Member
|
Updated to fix some failures we introduced on the main branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for this PR. I am working on a more comprehensive fix that is inspired by a suggestion @ncoghlan made on the original implementation PR: keeping a state-file that manages all .pth and .start file state internally. By doing this, we make it structurally impossible for reentrant calls to step on each other. I'll leave this PR open for now and we can compare. My PR will be larger and more complicated, but I think it's the right direction to go in because it also means fewer global state variables. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy and clear pending startup file data before executing import lines or .start entry points so recursive site.addsitedir() calls process a separate batch.
Fixes #149504