gh-149532: Remove bool.__invert__ magic method - #149533
Open
sobolevn wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
sergey-miryanov
approved these changes
May 8, 2026
sergey-miryanov
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
👍
Sorry, something went wrong.
johnslavik
reviewed
May 8, 2026
Comment thread
Doc/whatsnew/3.16.rst
| * Bitwise inversion on boolean types, ``~True`` or ``~False`` | ||
| has been deprecated since Python 3.12, | ||
| as it produces surprising and unintuitive results (``-2`` and ``-1``). | ||
| Use ``not x`` instead for the logical negation of a Boolean. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| Use ``not x`` instead for the logical negation of a Boolean. | |
| Use ``not x`` instead for the logical negation of a boolean. |
Sorry, something went wrong.
Comment thread
Lib/test/test_bool.py
Comment on lines
+160
to
+175
| msg = re.escape("bad operand type for unary ~: 'bool'") | ||
|
|
||
| # Check constants in case of a folding: | ||
| with self.assertRaisesRegex(TypeError, msg): | ||
| ~False | ||
| with self.assertRaisesRegex(TypeError, msg): | ||
| ~True | ||
|
|
||
| # Check variable: | ||
| for bool_val in [True, False]: | ||
| with self.subTest(bool_val), self.assertRaisesRegex(TypeError, msg): | ||
| ~bool_val | ||
|
|
||
| # Check `eval`: | ||
| with self.assertRaisesRegex(TypeError, msg): | ||
| eval("~False") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Curious if those shouldn't be subtests
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
See https://discuss.python.org/t/bool-deprecation/62232/128 for the context. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 90 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #82012
CC @hauntsaninja, @JelleZijlstra, @gvanrossum who reviewed #103487