Repository navigation
gh-79638: Treat an unreachable robots.txt as "disallow all" (GH-138555) - #149541
Closed
serhiy-storchaka wants to merge 1 commit into
Closed
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…thonGH-138555) Disallow all access in urllib.robotparser if the robots.txt file is unreachable due to server or network errors.
Copy link
Copy Markdown
Member
Author
|
I am puzzled. Tests on Android and iOS fail because they modify urllib.requests._opener. But there is an explicit cleanup code for it. The only difference is that it is now a class cleanup instead of a separate test cleanup, and the server and the thread are ran at the class level (for performance). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It turned out that the explicit check is not needed, because the current code passes the required tests. It may be needed in future, when we change the code (for example, to allow reloading of robots.txt). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disallow all access in urllib.robotparser if the robots.txt file is unreachable due to server or network errors.