Repository navigation
gh-150032: Tidy up 3.15 pending removals - #149594
hugovk merged 11 commits into
Conversation
Sorry, something went wrong.
Documentation build overview36 files changed · ± 36 modified ± Modified
|
Sorry, something went wrong.
hugovk
left a comment
There was a problem hiding this comment.
Thanks for updating this, and the 3.15->3.16 bumps should also be backported.
Sorry, something went wrong.
willingc
left a comment
There was a problem hiding this comment.
Thanks @StanFromIreland
Sorry, something went wrong.
Co-authored-by: Savannah Ostrowski <savannah@python.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
We could still do it in 3.15 with @hugovk approval. |
Sorry, something went wrong.
Co-authored-by: Brett Cannon <brett@python.org>
In recent release cycles, we've had feedback that it was too early to remove some things during pre/early alpha and added them back, so I'm a bit cautious about doing during beta. But if someone wants to do so, please first check things like the top PyPI packages/GitHub/grep.app to get an idea if they're still too widely used, and maybe we can do it before b2. |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
savannahostrowski
left a comment
There was a problem hiding this comment.
One question but otherwise, LGTM
Sorry, something went wrong.
| * Setting :attr:`~module.__package__` on a module while | ||
| failing to set :attr:`__spec__.parent <importlib.machinery.ModuleSpec.parent>` | ||
| is deprecated. In Python 3.16, :attr:`!__package__` will cease to be | ||
| taken into consideration by the import system or standard library. (:gh:`97879`) |
There was a problem hiding this comment.
| * Setting :attr:`~module.__package__` on a module while | |
| failing to set :attr:`__spec__.parent <importlib.machinery.ModuleSpec.parent>` | |
| is deprecated. In Python 3.16, :attr:`!__package__` will cease to be | |
| taken into consideration by the import system or standard library. (:gh:`97879`) | |
| * Setting :attr:`~module.__package__` on a module while | |
| failing to set :attr:`__spec__.parent <importlib.machinery.ModuleSpec.parent>` | |
| is deprecated. In Python 3.16, :attr:`!__package__` will cease to be set or | |
| taken into consideration by the import system or standard library. (:gh:`97879`) |
I'm not sure that the drop of "set or" was intentional here? It seems that the language changed from the 3.15 pending.
Sorry, something went wrong.
There was a problem hiding this comment.
It was Brett's change: d4926e0
Sorry, something went wrong.
There was a problem hiding this comment.
But why 🙂 ?
Sorry, something went wrong.
There was a problem hiding this comment.
I'm mainly curious because the __loader__ bullet directly above still uses "set or taken into consideration" language. To an end user the two phrasings probably don't really mean different things, either way the guidance is "stop relying on it", so the divergence between the two bullets reads as accidental.
Sorry, something went wrong.
There was a problem hiding this comment.
Because we tried to remove ever reading __package__ and pip broke. So we don't set in anymore in 3.15, but we are not at a place where we can stop reading it if gets set. As for __loader__, it's a different stage of going away.
Sorry, something went wrong.
|
I'll leave this one for the RMs to merge. |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
Co-authored-by: Savannah Ostrowski <savannah@python.org> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Brett Cannon <brett@python.org>
This moves all the things we planned to remove in 3.15 but didn't to the appropriate pending removal in 3.16 file.
Additionally, move a misplaced entry from the 3.16 C-API removals file to the 3.16 main file removals.