gh-148871: Add CONSTANT_EMPTY_TUPLE to LOAD_COMMON_CONSTANT - #149688
Merged
markshannon merged 3 commits intoMay 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
eendebakpt
requested review from
FFY00,
ZeroIntensity,
ericsnowcurrently,
iritkatriel and
markshannon
as code owners
May 11, 2026 15:24
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
eendebakpt
force-pushed
the
load-common-const-empty-tuple
branch
from
84e6f85 to
79cc39d
Compare
May 11, 2026 15:28
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member
|
There are, inevitably, merge conflicts. |
Sorry, something went wrong.
…ty-tuple # Conflicts: # Include/internal/pycore_opcode_utils.h # Lib/opcode.py # Python/pylifecycle.c
markshannon
approved these changes
May 21, 2026
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add () as a new value for LOAD_COMMON_CONSTANT, following the existing pattern used for "" (CONSTANT_EMPTY_STR). The compiler now folds LOAD_CONST () into LOAD_COMMON_CONSTANT 12, dropping the entry from co_consts.
() is the most common constant left in co_consts after the existing LOAD_COMMON_CONSTANT rewrites. Frequencies in co_consts (top-level entries, recursing into nested code objects):
Common sources of (): __slots__ = (), empty default-args tuples passed to MAKE_FUNCTION, __reduce__ returning (), etc.
b"" and ... are already immortal singletons, but less frequent. For reviewers: should we add these as well?