Repository navigation
gh-150565: Add additional tests for Lazy Imports - #149739
Merged
DinoV merged 5 commits intoJun 23, 2026
Merged
DinoV merged 5 commits into
DinoV merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
brittanyrey
force-pushed
the
add-lazy-import-tests
branch
from
28ae182 to
15f157e
Compare
May 12, 2026 17:53
Port missing test coverage from the internal lazy imports test suite, covering behaviors not previously tested in cpython: - Dict operations with lazy values (copy, |, update preserve proxies) - Submodule laziness (unaccessed imports stay lazy until touched) - Attribute side effects (submodule imports don't overwrite parent attrs) - Module/variable name collisions (submodule vs variable ordering) - Deleted module reimport (sys.modules deletion and reimport) - Circular import resolution (lazy imports breaking circular deadlocks) - Dict mutation during module loading (no crash on dict resize) Adds supporting test data modules: metasyntactic package hierarchy, versioned package, module_same_name_var_order packages, and circular_import_pkg.
brittanyrey
force-pushed
the
add-lazy-import-tests
branch
from
15f157e to
4f945a4
Compare
May 22, 2026 16:05
- Remove trailing newlines from empty __init__.py files to satisfy pre-commit hooks - Fix test_fails_without_lazy to not pass invalid -X lazy_imports=none flag - Add 14 new test data directories to TESTSUBDIRS in Makefile.pre.in Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
brittanyrey
marked this pull request as ready for review
May 28, 2026 19:39
brittanyrey
requested review from
AA-Turner,
DinoV,
Yhg1s,
emmatyping,
erlend-aasland and
pablogsal
as code owners
May 28, 2026 19:39
pablogsal
reviewed
May 29, 2026
Comment thread
Lib/test/test_lazy_import/__init__.py
Outdated
pablogsal
reviewed
May 29, 2026
Comment thread
Lib/test/test_lazy_import/__init__.py
Outdated
…evant implementation detail from pep690
Copy link
Copy Markdown
Contributor
Author
|
Addressed comments. |
Sorry, something went wrong.
DinoV
approved these changes
May 29, 2026
pyctrl
pushed a commit
to pyctrl/cpython
that referenced
this pull request
Jul 5, 2026
Add lazy import tests ported from internal test suite
Copy link
Copy Markdown
|
Thanks @brittanyrey for the PR, and @DinoV for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @brittanyrey and @DinoV, I could not cleanly backport this to 3.15 due to a conflict. Please backport manually with cherry_picker, see the devguide for more information. cherry_picker 10d1b63ed8b0261e7a9b7ffc3231eafd89187a4b 3.15 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-158614 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
hugovk
added a commit
that referenced
this pull request
Oct 2, 2026
Kronuz
pushed a commit
to Kronuz/cpython
that referenced
this pull request
Oct 5, 2026
…GH-149739) (python#158614) Co-authored-by: Brittany Reynoso <breynoso@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a lot of Lazy Import tests in the Cinder/MetaPython Lazy Imports test suite that should also be useful for Cpython. Porting some tests over to increase coverage--especially around lazy_imports=all.
Adds supporting test data modules.
#150565