gh-115119: remove TEST_COVERAGE private macro (_decimal module) - #149756
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
Please change PR title to explain the change rather than referring to a commit sha1. Please elaborate also on why you made this change and what is its purpose.
Sorry, something went wrong.
|
So, I had to reverse engineer your change... This change no longer defines TEST_COVERAGE macro when building the _decimal extension with a Python debug build (--with-pydebug). It seems like the TEST_COVERAGE macro was introduced by the commit 97b4121 (issue gh-94847 and PR gh-94848) to fix building the _decimal with --with-pydebug --with-lto (debug mode with LTO). In the libmpdec-2.5.1 copy embedded in Python 3.15, I can see that the TEST_COVERAGE macro has an effect on inlining: #if defined(_MSC_VER)
#define ALWAYS_INLINE __forceinline
#elif defined (__IBMC__) || defined(LEGACY_COMPILER)
#define ALWAYS_INLINE
#undef inline
#define inline
#else
#ifdef TEST_COVERAGE
#define ALWAYS_INLINE
#else
#define ALWAYS_INLINE inline __attribute__ ((always_inline))
#endif
#endifThe bundled copy of the libmpdec decimal library has been removed in the main branch. So it's no longer needed to define the TEST_COVERAGE variable. |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
| */ | ||
|
|
||
| #ifdef TEST_COVERAGE | ||
| #ifdef Py_DEBUG |
There was a problem hiding this comment.
I wonder if we should go so far as to do this in Include/pyport.h, but that's not a decision I will be making.
Sorry, something went wrong.
This amends 9eb3b14. Use unstead Py_DEBUG.