gh-148675: Reuse typecodes for array.array() error message - #149779
Merged
vstinner merged 1 commit intoMay 15, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
array.array() error message now reuses array.typecodes, instead of maintaining an hardcoded list of valid type codes.
Copy link
Copy Markdown
Member
Author
|
Example: import array
array.array('v')Output: Traceback (most recent call last):
File "/home/vstinner/python/main/x.py", line 2, in <module>
array.array('v')
~~~~~~~~~~~^^^^^
ValueError: bad typecode (must be: b, B, u, w, h, H, i, I, l, L, q, Q, e, f, d, Zf, Zd)
|
Sorry, something went wrong.
skirpichev
approved these changes
May 14, 2026
Copy link
Copy Markdown
Member
Author
|
Merged, thanks for the review. I wrote this change since recently, I noticed that 3 type codes were missing from this error message. I fixed the error message, but with this change it's no longer neeeded (it's always up to date). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array.array() error message now reuses array.typecodes, instead of maintaining an hardcoded list of valid type codes.