Repository navigation
gh-149879: Don't import msvcrt in _pyio on Cygwin - #149899
Merged
vstinner merged 1 commit intoMay 15, 2026
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The msvcrt extension module cannot be built on Cygwin.
Copy link
Copy Markdown
Member
Author
|
This change fix a regression introduced by commit f0f55a0 in 2015. It does fix the issue reported in 2016: #69069 (comment). |
Sorry, something went wrong.
vstinner
enabled auto-merge (squash)
May 15, 2026 20:20
Copy link
Copy Markdown
Member
Author
|
The macos-26 job failed with: FAIL: test_trampoline_works_with_forks (test.test_perf_profiler.TestPerfTrampoline.test_trampoline_works_with_forks)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/runner/work/cpython/cpython/Lib/test/test_perf_profiler.py", line 145, in test_trampoline_works_with_forks
self.assertEqual(process.returncode, 0)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 11 != 0
That's the unrelated issue gh-149156. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The msvcrt extension module cannot be built on Cygwin.