Repository navigation
gh-146406: add clear() cross-language hint for immutable types - #149927
Merged
ZeroIntensity merged 1 commit intoMay 20, 2026
Merged
ZeroIntensity merged 1 commit into
ZeroIntensity merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Follow-up to PR python#146407. Calling .clear() on a tuple, frozenset, or frozendict now suggests the mutable counterpart (list / set / dict), mirroring the existing append/extend/insert/remove/discard/update entries for the same immutable types. Triggered by @henryiii noticing that .clear() was the first method they tried on these types and got no useful suggestion, and @vstinner agreeing it was worth adding. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
vstinner
approved these changes
May 18, 2026
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
@ZeroIntensity @picnixz: Do you want to double check the change?
Sorry, something went wrong.
picnixz
approved these changes
May 19, 2026
picnixz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
ZeroIntensity
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #146407. Calling .clear() on a tuple, frozenset, or frozendict now suggests the mutable counterpart, mirroring the existing append/extend/insert/remove/discard/update entries for the same immutable types.
Requested by @vstinner after @henryiii flagged that .clear() was the first method they tried on these types in the new hint table from #146407 and got no useful suggestion.
>>> (1, 2, 3).clear() AttributeError: 'tuple' object has no attribute 'clear'. Did you mean to use a 'list' object? >>> frozenset({1, 2, 3}).clear() AttributeError: 'frozenset' object has no attribute 'clear'. Did you mean to use a 'set' object?Verified locally: ./python.exe -m test test_traceback 434/434 passing.