Repository navigation
gh-145306: Fix browser open after empty export - #150017
Merged
pablogsal merged 2 commits intoJun 27, 2026
Merged
pablogsal merged 2 commits into
pablogsal merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
maurycy
reviewed
May 19, 2026
Comment thread
Lib/profiling/sampling/cli.py
Outdated
Make sampling exporters report whether output was generated, and only open HTML reports in the browser after a successful export.
lkollar
force-pushed
the
tachyon/fix-browser-open
branch
from
e98a58b to
4334b0f
Compare
May 21, 2026 15:51
pablogsal
approved these changes
Jun 27, 2026
Copy link
Copy Markdown
|
Thanks @ivonastojanovic for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-152447 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
pablogsal
pushed a commit
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sampling exporters report whether output was generated, and only open HTML reports in the browser after a successful export.