Repository navigation
[3.15] gh-86533: Restore os.makedirs() ability to apply *mode* recursively (GH-150011) - #150036
Merged
gpshead merged 2 commits intoMay 19, 2026
Merged
gpshead merged 2 commits into
gpshead merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…vely (pythonGH-150011) bpo-42367: Restore os.makedirs() and pathlib.mkdir() ability to apply *mode* recursively via a new parent_mode= keyword argument. (cherry picked from commit 9770e32) Co-authored-by: nessita <124304+nessita@users.noreply.github.com> Co-authored-by: Zackery Spytz <zspytz@gmail.com> Co-authored-by: Erlend E. Aasland <erlend@python.org> Co-authored-by: Natalia <124304+nessita@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead
enabled auto-merge (squash)
May 18, 2026 23:03
gpshead
approved these changes
May 18, 2026
Copy link
Copy Markdown
Member
|
there's some buildbot failures (the joy of tests relying on filesystem modes in various environments) on the first PR. I'll deal with those and incorporate fixes here before merging this. |
Sorry, something went wrong.
test_mkdir_with_parent_mode, test_mkdir_parent_mode_deep_hierarchy and test_mkdir_parent_mode_same_as_mode assert exact directory mode bits but did not pin the process umask. On buildbots running with a restrictive umask (e.g. 0o077) the 0o755 leaf was masked down to 0o700, failing the assertions. Wrap them in os_helper.temp_umask(0o022), matching the other umask-aware mkdir tests in this file.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @gpshead for commit 036510e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150036%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-42367: Restore os.makedirs() and pathlib.mkdir() ability to apply mode recursively via a new parent_mode= keyword argument.
(cherry picked from commit 9770e32)
Co-authored-by: nessita 124304+nessita@users.noreply.github.com
Co-authored-by: Zackery Spytz zspytz@gmail.com
Co-authored-by: Erlend E. Aasland erlend@python.org
Co-authored-by: Natalia 124304+nessita@users.noreply.github.com
Co-authored-by: Gregory P. Smith greg@krypto.org
Fixes #86533