Pull request overview

This PR extends CPython’s zipapp test suite by adding a new subprocess-driven test class that exercises the real python -m zipapp command-line interface, complementing the existing in-process zipapp.main() CLI tests.

Changes:

• Add a CommandLineTest class that runs python -m zipapp in a subprocess and validates key CLI behaviors (--help, create/copy archives, --info, and common error cases).
• Add a NEWS entry documenting the new subprocess-based CLI coverage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Lib/test/test_zipapp.py:561

• This test currently treats any non-zero exit as success. To avoid false positives, also assert that stderr includes the specific message for in-place archive edits ("In-place editing of archives is not supported").

    def test_copy_archive_inplace_fails(self):
        original = self._make_archive()
        result = self._run(str(original), '-o', str(original))
        self.assertNotEqual(result.returncode, 0)

Lib/test/test_zipapp.py:567

• Similar to the other negative tests, this only asserts a non-zero return code. To prevent the test passing for an unrelated failure mode, also check stderr contains the expected message for attempting to change the main function when copying ("Cannot change the main function when copying").

    def test_copy_archive_change_main_fails(self):
        original = self._make_archive()
        target = self.tmpdir / 'copy.pyz'
        result = self._run(str(original), '-o', str(target), '-m', 'foo:bar')
        self.assertNotEqual(result.returncode, 0)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.