gh-150213: Fix OOM error handling in _interpchannels - #150214
Closed
lpyu001 wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Author
|
The runner was terminated during task execution. Could you please retrigger the failed job? Thank you. @aisk |
Sorry, something went wrong.
sobolevn
reviewed
May 23, 2026
Comment thread
Modules/_interpchannelsmodule.c
Outdated
| @@ -922,6 +922,7 @@ _channelends_new(void) | |||
| { | |||
| _channelends *ends = GLOBAL_MALLOC(_channelends); | |||
| if (ends== NULL) { | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| if (ends== NULL) { | |
| if (ends == NULL) { |
style change, while we are here
Sorry, something went wrong.
Comment thread
Lib/test/test__interpchannels.py
| try: | ||
| try: | ||
| cid = _channels.create(REPLACE) | ||
| except MemoryError: |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
you can use with self.assertRaises(MemoryError):
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.