Repository navigation
gh-149800: Fix macOS universal2 build of perf trampoline (GH-149894 follow-up) - #150364
Merged
pablogsal merged 3 commits intoMay 25, 2026
Merged
pablogsal merged 3 commits into
pablogsal merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pablogsal
requested review from
AA-Turner,
emmatyping and
erlend-aasland
as code owners
May 24, 2026 19:33
…nGH-149894 follow-up) After the perf trampoline assembly was split into per-architecture files, the macOS universal2 build failed at the lipo step: fatal error: lipo: Python/asm_trampoline_aarch64.o and Python/asm_trampoline_x86_64.o have the same architectures (x86_64) and can't be in the same fat output file PY_CORE_CFLAGS on universal2 contains "-arch arm64 -arch x86_64", so each .S file was assembled into a fat .o containing both slices (with one slice empty because of the #ifdef guards). lipo then refused to merge two fat objects that share architectures. Compile each per-arch object with a single -arch flag before merging.
pablogsal
force-pushed
the
fix-perf-trampoline-mac-universal2
branch
from
6ca47af to
cf94a02
Compare
May 24, 2026 19:36
stratakis
reviewed
May 24, 2026
Comment thread
Makefile.pre.in
pablogsal
commented
May 24, 2026
Comment thread
Makefile.pre.in
vstinner
reviewed
May 25, 2026
Comment thread
Makefile.pre.in
Outdated
Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
After the perf trampoline assembly was split into per-architecture files, the macOS universal2 build failed at the lipo step:
PY_CORE_CFLAGS on universal2 contains "-arch arm64 -arch x86_64", so each .S file was assembled into a fat .o containing both slices (with one slice empty because of the #ifdef guards). lipo then refused to merge two fat objects that share architectures.
Compile each per-arch object with a single -arch flag before merging.