Repository navigation
gh-149879: Fix test_asyncio on Cygwin - #150416
Merged
vstinner merged 2 commits intoMay 25, 2026
Merged
vstinner merged 2 commits into
vstinner merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Skip tests on UNIX sockets since they hang on Cygwin.
Copy link
Copy Markdown
Member
Author
|
The fix is incomplete, the following tests still fail: test_asyncio.test_events
test_ssl_connect_accepted_socket()
test_subprocess_kill()
test_subprocess_terminate()
test_subprocess_send_signal()
test_subprocess_stderr()
test_subprocess_stderr_redirect_to_stdout()
test_asyncio.test_ssl
test_remote_shutdown_receives_trailing_data_on_slow_socket()
test_asyncio.test_subprocess
test_cancel_post_init()
|
Sorry, something went wrong.
vstinner
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
May 25, 2026 20:08
Copy link
Copy Markdown
Member
Author
|
I found a fix for subprocess tests (use a socketpair for stdin). test_remote_shutdown_receives_trailing_data_on_slow_socket() stil hangs. It can be fixed later. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip tests on UNIX sockets since they hang on Cygwin.