Repository navigation
gh-149879: Fix test_ftplib on Cygwin - #150431
Merged
vstinner merged 1 commit intoMay 25, 2026
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Skip test_abort() since MSG_OOB doesn't work properly on Cygwin. The server gets b'\n' and then b'ABOR\r', instead of getting b'ABOR\r\n'.
Copy link
Copy Markdown
Member
Author
|
I found a reference to MSG_OOB in Cygwin in 2018 with this fix: https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=9c84bfd47922aad4881f80243320422b621c95dc. Well, it's supposed to be fixed. |
Sorry, something went wrong.
giampaolo
approved these changes
May 25, 2026
giampaolo
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip test_abort() since MSG_OOB doesn't work properly on Cygwin. The server gets b'\n' and then b'ABOR\r', instead of getting b'ABOR\r\n'.