gh-148508: Add another common pattern for iOS SSL failures by freakboy3742 · Pull Request #150442 · python/cpython · GitHub

The test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_server test fails intermittently on the iOS buildbot because an SSL error doesn't raise the expected TLS handshake error.

This test already has an escape clause that allows a skip under certain error conditions (raising a ConnectionError, an OSError, or an SSL error with "wrong version number"). #148536 added a pattern for one type of iOS failure; this PR adds a second failure mode that is observed (simplifying the test into a single regex).

It also tweaks the iOS logging regex to strip an additional space; this should aid Bevedere in reporting stack traces when failures occur.

Issue: Intermittent iOS buildbot failure in test_preauth_data_to_tls_server #148508

!buildbot iOS

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 5e9b009 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150442%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

iOS ARM64 Simulator PR

Nitpick:

Suggested change

      
                            re.I
          
                            re.IGNORECASE

LGTM.

Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

GH-150697 is a backport of this pull request to the 3.15 branch.

GH-150698 is a backport of this pull request to the 3.14 branch.

GH-150699 is a backport of this pull request to the 3.13 branch.

Merged, thanks for the fix @freakboy3742.

…test_ssl (GH-150442) (#150698) gh-148508: Add another common pattern for iOS SSL failures to test_ssl (GH-150442) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.15 (tier-1) has failed when building commit a4f3336.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/2019/builds/120) and take a look at the build logs.
Check if the failure is related to this commit (a4f3336) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/2019/builds/120

Failed tests:

test.test_multiprocessing_fork.test_processes

Failed subtests:

test_interrupt - test.test_multiprocessing_fork.test_processes.WithProcessesTestProcess.test_interrupt

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/contextlib.py", line 116, in inner
    return func(*args, **kwds)
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 649, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/contextlib.py", line 116, in inner
    return func(*args, **kwds)
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 630, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 303, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 626, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-158' pid=1657692 parent=1657134 started daemon>


Traceback (most recent call last):
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/contextlib.py", line 116, in inner
    return func(*args, **kwds)
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 649, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/contextlib.py", line 116, in inner
    return func(*args, **kwds)
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 630, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 303, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 626, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-1' pid=1680348 parent=1680346 started daemon>

…es to test_ssl (pythonGH-150442) (python#150699) pythongh-148508: Add another common pattern for iOS SSL failures to test_ssl (pythonGH-150442) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

The ARM64 macOS 3.11 builder has failed three times in a row:

======================================================================
FAIL: test_preauth_data_to_tls_server (test.test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_server)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.11.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py", line 5099, in test_preauth_data_to_tls_server
    self.assertIn("before TLS handshake with data", wrap_error.args[1])
AssertionError: 'before TLS handshake with data' not found in '[SSL: HTTP_REQUEST] http request (_ssl.c:1016)'

----------------------------------------------------------------------

https://buildbot.python.org/#/builders/1030

This follows upgrades for macOS 26.2->26.6.2 and OpenSSL 3.6.1->3.6.3 on the worker, and the 3.12 builder also failed for its first build after the upgrade:
https://buildbot.python.org/#/builders/1206/builds/1627

3.10 is likely affected, but hasn't run since.

Not every run fails, but these security branches don't run very often.

We've already made the test more robust, and backported it to 3.13. Let's now backport the Lib/test/test_ssl.py change for 3.12-3.10.

Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

Sorry, @freakboy3742 and @vstinner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 540b3d0a7fa7cd842f064f79b1410cbd6868bffa 3.10

Sorry, @freakboy3742 and @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 540b3d0a7fa7cd842f064f79b1410cbd6868bffa 3.11

Sorry, @freakboy3742 and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 540b3d0a7fa7cd842f064f79b1410cbd6868bffa 3.12

GH-158246 is a backport of this pull request to the 3.12 branch.

GH-158247 is a backport of this pull request to the 3.11 branch.

GH-158248 is a backport of this pull request to the 3.10 branch.

…test_ssl (GH-150442) (#158246) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

…test_ssl (GH-150442) (#158248) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

…test_ssl (GH-150442) (#158247) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

…es to test_ssl (pythonGH-150442) (python#150699) pythongh-148508: Add another common pattern for iOS SSL failures to test_ssl (pythonGH-150442) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

freakboy3742 added 2 commits May 26, 2026 10:10

Add another common pattern for iOS SSL failures

3f9623e

Strip an additional whitespace from the start of log lines.

5e9b009

freakboy3742 requested review from gpshead and picnixz as code owners May 26, 2026 02:19

freakboy3742 added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels May 26, 2026

bedevere-app Bot added the awaiting core review label May 26, 2026

bedevere-app Bot mentioned this pull request May 26, 2026

Intermittent iOS buildbot failure in test_preauth_data_to_tls_server #148508

Closed

freakboy3742 requested a review from vstinner May 26, 2026 02:49

vstinner reviewed May 28, 2026

View reviewed changes

freakboy3742 added 2 commits May 31, 2026 11:18

Clarify the original messages being matched.

7328a2b

Merge branch 'main' into ios-ssl-tests

f1122a8

freakboy3742 requested a review from vstinner May 31, 2026 03:58

vstinner approved these changes Jun 1, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 1, 2026

vstinner merged commit 540b3d0 into python:main Jun 1, 2026
53 checks passed

bedevere-app Bot removed the awaiting merge label Jun 1, 2026

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 1, 2026

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 1, 2026

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 1, 2026

hugovk added needs backport to 3.10 needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 26, 2026

miss-islington-app Bot assigned vstinner Sep 26, 2026

hugovk mentioned this pull request Sep 26, 2026

[3.12] gh-148508: Add another common pattern for iOS SSL failures to test_ssl (GH-150442) #158246

Merged

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 26, 2026

hugovk mentioned this pull request Sep 26, 2026

[3.11] gh-148508: Add another common pattern for iOS SSL failures to test_ssl (GH-150442) #158247

Merged

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 26, 2026

hugovk mentioned this pull request Sep 26, 2026

[3.10] gh-148508: Add another common pattern for iOS SSL failures to test_ssl (GH-150442) #158248

Merged

bedevere-app Bot removed the needs backport to 3.10 label Sep 26, 2026

+                          re.search(
+                              r'wrong.version.number|record.layer.failure|http.request',
+                              str(getattr(err, "reason", "")),
+                              re.I

gh-148508: Add another common pattern for iOS SSL failures by freakboy3742 · Pull Request #150442 · python/cpython · GitHub

Repository navigation

gh-148508: Add another common pattern for iOS SSL failures - #150442

gh-148508: Add another common pattern for iOS SSL failures#150442vstinner merged 4 commits intopython:mainpython/cpython:mainfrom freakboy3742:ios-ssl-testsfreakboy3742/cpython:ios-ssl-testsCopy head branch name to clipboard

Conversation

freakboy3742 commented May 26, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

freakboy3742 commented May 26, 2026

Uh oh!

bedevere-bot commented May 26, 2026

Uh oh!

Uh oh!

vstinner May 28, 2026

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Jun 1, 2026

Uh oh!

bedevere-app Bot commented Jun 1, 2026

Uh oh!

bedevere-app Bot commented Jun 1, 2026

Uh oh!

bedevere-app Bot commented Jun 1, 2026

Uh oh!

vstinner commented Jun 1, 2026

Uh oh!

bedevere-bot commented Jun 1, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

hugovk commented Sep 26, 2026

Uh oh!

miss-islington-app Bot commented Sep 26, 2026

Uh oh!

miss-islington-app Bot commented Sep 26, 2026

Uh oh!

miss-islington-app Bot commented Sep 26, 2026

Uh oh!

miss-islington-app Bot commented Sep 26, 2026

Uh oh!

miss-islington-app Bot commented Sep 26, 2026

Uh oh!

miss-islington-app Bot commented Sep 26, 2026

Uh oh!

bedevere-app Bot commented Sep 26, 2026

Uh oh!

bedevere-app Bot commented Sep 26, 2026

Uh oh!

bedevere-app Bot commented Sep 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-148508: Add another common pattern for iOS SSL failures#150442
vstinner merged 4 commits into
python:mainfrom
freakboy3742:ios-ssl-tests

freakboy3742 commented May 26, 2026 •
edited by bedevere-app Bot
Loading