Repository navigation
gh-150886: Remove unused importlib._bootstrap._object_name - #150884
brettcannon merged 3 commits into
Conversation
Sorry, something went wrong.
Introduced in pythonGH-23469 (bpo-26131, "Deprecate usage of load_module()") to render an object's qualified name inside the load_module() deprecation warnings. Orphaned by pythongh-142205 (pythonGH-97850, "Remove all uses and definitions of load_module() from importlib"), which deleted the warning-building call sites f"{_object_name(spec.loader)}.exec_module() not found; ..." and left the helper with no caller. A word-boundary search across Lib, Modules, Python, Objects and Include finds zero references outside its own definition, and a GitHub code search finds no downstream importers. The frozen importlib was regenerated; importlib._bootstrap._object_name no longer exists at runtime and the full test_importlib suite passes.
|
I would be careful here. People arr known to use private functions of importlib even in private projects because sometimes there is not better replacement so I do not think we need to really remove it without a notificationat least. So please create a NEWS entry. |
Sorry, something went wrong.
|
Thanks. I've added a NEWS entry. On the broader concern: before proposing this I ran a GitHub code search for importlib._bootstrap._object_name and from importlib._bootstrap import _object_name and found no downstream importers, which is why I scoped the PR to just this symbol. It only rendered an object's qualname for the load_module() deprecation warnings that gh-142205 removed, so it has no remaining caller in or out of the tree that I can find. A code search only reaches public code though, so private users could exist that we will never see. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot x86-64 MacOS Intel ASAN NoGIL 3.x (tier-2) has failed when building commit f906522. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1366/builds/7075 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_logging.py", line 6666, in test_rollover_based_on_st_birthtime_only
self.assertTrue(found, msg=msg)
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: False is not true : No rotated files found, went back 5 seconds
|
Sorry, something went wrong.
…hon#150884) Introduced in pythonGH-23469 (bpo-26131, "Deprecate usage of load_module()") to render an object's qualified name inside the load_module() deprecation warnings. Orphaned by pythongh-142205 (pythonGH-97850, "Remove all uses and definitions of load_module() from importlib"), which deleted the warning-building call sites f"{_object_name(spec.loader)}.exec_module() not found; ..." and left the helper with no caller. A word-boundary search across Lib, Modules, Python, Objects and Include finds zero references outside its own definition, and a GitHub code search finds no downstream importers. The frozen importlib was regenerated; importlib._bootstrap._object_name no longer exists at runtime and the full test_importlib suite passes.
importlib._bootstrap._object_name() arrived in GH-23469 (bpo-26131) to render an object's qualified name inside the load_module() deprecation warnings. gh-142205 (GH-97850) removed load_module() and those warnings, deleting the last call site, so the private helper now has no caller.
Nothing in the repository references the name outside its own definition, and a GitHub code search turns up no downstream importer. Removing it from Lib/importlib/_bootstrap.py and regenerating the frozen module drops it from the runtime.
_object_name is private and undocumented, so this has no user-facing effect and needs no Misc/NEWS.d entry. The skip news label applies.