Repository navigation
gh-150913: Fix sqlite3.Blob validation for empty slice assignment - #150915
Merged
serhiy-storchaka merged 1 commit intoJun 4, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ass_subscript_slice() returned early when the computed slice length was zero, bypassing validation performed for non-empty slices. Move validation before the empty-slice fast path so that invalid assignments raise the appropriate exception regardless of slice length.
ever0de
force-pushed
the
gh-150913-fix-blob-empty-slice-validation
branch
from
9fd8656 to
e7fdb62
Compare
June 4, 2026 12:53
ever0de
marked this pull request as ready for review
June 4, 2026 12:55
serhiy-storchaka
approved these changes
Jun 4, 2026
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. 👍
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @ever0de for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-150923 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-150924 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-150925 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
philthompson10
pushed a commit
to philthompson10/cpython
that referenced
this pull request
Jun 17, 2026
…nt (pythonGH-150915) ass_subscript_slice() returned early when the computed slice length was zero, bypassing validation performed for non-empty slices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ass_subscript_slice() returned early when the computed slice length was zero, bypassing validation performed for non-empty slices.
Move validation before the empty-slice fast path so that invalid assignments raise the appropriate exception regardless of slice length.