gh-151128: Improve SyntaxError message for cross language keywords by zang-langyan · Pull Request #151129 · python/cpython · GitHub

I do not think that it is needed to add 'switch' to keywords.

Even if we only add one special case, it is worth to write more general code which will allow to add more keywords in future. See #146407 as example.

I do not think that it is needed to add 'switch' to keywords.

Even if we only add one special case, it is worth to write more general code which will allow to add more keywords in future. See #146407 as example.

Thank you for the reference, it is really a good example. I will look into it.

You can split this on two features -- for keywords and for operators.

Anyway, it needs a NEWS entry, a What's New entry, and tests.

Nice. This is actually a different feature. You can even open a separate issue and PR for this (if there is no already open). Anyway, this is a nice improvement.

I suggest to add also cases for <> ("not equal" in Pascal and Python 2), "=<", "=>" and "=!" (typo in "<=", ">=" and "!="), "===" ("is" in JavaScript and PHP).

Actually there is already a PR for improving SyntaxError message of && and ||: #150906

Thank you for review, great suggestion, I will add those~

Then let's focus on keywords in this PR.

Suggested change

      
                        matches.extend(difflib.get_close_matches(wrong_name, keyword.kwlist, n=max_matches, cutoff=0.5))
          
                        matches.extend(difflib.get_close_matches(wrong_name, keyword.kwlist+keyword.softkwlist, n=max_matches, cutoff=0.5))

Maybe we should add softkwlist here too?

Could you please add also tests for soft keywords? And document this change in the NEWS entry.

Why aliases for None were removed? Were there issues with them?

Could you please add also tests for soft keywords? And document this change in the NEWS entry.

Why aliases for None were removed? Were there issues with them?

Sure, I will add the tests for soft keywords.

I removed the aliases for None because I realized that names like Null, nil, etc. don't work well for keyword syntax detection. I can't think of a situation where these tokens would be correctly identified as keywords. Any suggestions?

You are right. Maybe they can be handled where NameError is handed.

Suggested change

      
                        hint = _get_cross_language_keyword_hint(wrong_name)
          
                        hint = _CROSS_LANGUAGE_KEYWORD_HINTS.get(wrong_name)

If it is only used once, and is marked as a "private" method, I would suggest calling the body directly

Not sure about this. I still think a get method looks nicer..

LGTM. 👍

…rds (pythonGH-151129)

zang-langyan added 2 commits June 9, 2026 15:58

pythongh-151128 Improve SyntaxError message for match

ba55af2

suggestion does not compute full match distance

bb0200a

bedevere-app Bot added the awaiting review label Jun 9, 2026

bedevere-app Bot mentioned this pull request Jun 9, 2026

Improve SyntaxError message for match #151128

Closed

This comment was marked as outdated.

Sign in to view

add cross language keyword hints list as a general implementation

3a2926f

zang-langyan requested review from lysnikolaou and pablogsal as code owners June 9, 2026 12:59

zang-langyan changed the title gh-151128: Improve SyntaxError message for match gh-151128: Improve SyntaxError message for cross language keywords Jun 9, 2026

trim trailing whitespace

27b89b6

edvilme reviewed Jun 10, 2026

View reviewed changes

Comment thread Lib/traceback.py Outdated

Comment on lines +1890 to +1891

hint = _CROSS_LANGUAGE_KEYWORD_HINTS.get(wrong_name)

return hint

This comment was marked as resolved.

Sign in to view

serhiy-storchaka reviewed Jun 10, 2026

View reviewed changes

IvyXu420 reviewed Jun 11, 2026

View reviewed changes

serhiy-storchaka mentioned this pull request Jun 11, 2026

gh-146495: Improve SyntaxError message for && and || operators #150906

Merged

Aniketsy mentioned this pull request Jun 11, 2026

Improve SyntaxError suggestions for common operator typos and cross-language mistakes #151303

Open

focus on keyword suggestion

f3cdecc

zang-langyan requested a review from serhiy-storchaka June 11, 2026 16:23

remove trailing whitespace

2cdd76e

serhiy-storchaka reviewed Jun 11, 2026

View reviewed changes

add test for soft keywords

bca2327

serhiy-storchaka reviewed Jun 11, 2026

View reviewed changes

Comment thread Lib/test/test_traceback.py

edvilme reviewed Jun 11, 2026

View reviewed changes

Comment thread Lib/traceback.py

edvilme reviewed Jun 11, 2026

View reviewed changes

zang-langyan added 2 commits June 12, 2026 11:36

add tests for keyword lazy and add void as another crosslang case

9e13d74

remove whitespace

896dd06

zang-langyan requested a review from serhiy-storchaka June 15, 2026 17:33

serhiy-storchaka approved these changes Jun 15, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 15, 2026

serhiy-storchaka merged commit 5ea1e90 into python:main Jun 15, 2026
55 checks passed

bedevere-app Bot removed the awaiting merge label Jun 15, 2026

philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026

pythongh-151128 : Improve SyntaxError message for cross language keywo…

82394ff

…rds (pythonGH-151129)

                   | a=expression ':=' expression {
                       RAISE_SYNTAX_ERROR_KNOWN_LOCATION(
                           a, "cannot use assignment expressions with %s", _PyPegen_get_expr_name(a)) }
+                  | a=expression '&''&' b=expression {

+                              suggestion = _suggestions._generate_suggestions(keyword.kwlist + keyword.softkwlist, wrong_name)
                               if suggestion:
                                   matches.append(suggestion)
                           matches.extend(difflib.get_close_matches(wrong_name, keyword.kwlist, n=max_matches, cutoff=0.5))

		hint = _CROSS_LANGUAGE_KEYWORD_HINTS.get(wrong_name)
		return hint

	matches.extend(difflib.get_close_matches(wrong_name, keyword.kwlist, n=max_matches, cutoff=0.5))
	matches.extend(difflib.get_close_matches(wrong_name, keyword.kwlist+keyword.softkwlist, n=max_matches, cutoff=0.5))

                           max_matches = 3
                           matches = []
+                          hint = _get_cross_language_keyword_hint(wrong_name)

	hint = _get_cross_language_keyword_hint(wrong_name)
	hint = _CROSS_LANGUAGE_KEYWORD_HINTS.get(wrong_name)

gh-151128: Improve SyntaxError message for cross language keywords by zang-langyan · Pull Request #151129 · python/cpython · GitHub

Repository navigation

gh-151128: Improve SyntaxError message for cross language keywords - #151129

gh-151128: Improve SyntaxError message for cross language keywords#151129serhiy-storchaka merged 9 commits intopython:mainpython/cpython:mainfrom zang-langyan:151128zang-langyan/cpython:151128Copy head branch name to clipboard

Conversation

zang-langyan commented Jun 9, 2026

Uh oh!

serhiy-storchaka commented Jun 9, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

zang-langyan commented Jun 9, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

IvyXu420 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

zang-langyan Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

IvyXu420 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

zang-langyan commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka commented Jun 11, 2026

Uh oh!

Uh oh!

Uh oh!

edvilme Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

zang-langyan Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-151128: Improve SyntaxError message for cross language keywords#151129
serhiy-storchaka merged 9 commits into
python:mainfrom
zang-langyan:151128

zang-langyan commented Jun 11, 2026 •
edited
Loading