gh-151126: Add PyErr_NoMemory() in strong_cache_node_new - #151137
Closed
sobolevn wants to merge 1 commit into
Closed
gh-151126: Add PyErr_NoMemory() in strong_cache_node_new#151137sobolevn wants to merge 1 commit into
sobolevn wants to merge 1 commit into
Conversation
StanFromIreland
requested changes
Jun 9, 2026
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is incorrect, we deliberately don't set the error here. The strong cache is an optimisation whose failure is harmless, the ZoneInfo instance has already been built successfully and gets returned regardless.
Sorry, something went wrong.
Comment thread
Modules/_zoneinfo.c
Comment on lines
2347
to
2350
| * This function doesn't set MemoryError if PyMem_Malloc fails, | ||
| * as the cache intentionally doesn't propagate exceptions | ||
| * and fails silently if error occurs. | ||
| */ |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
See this comment.
Sorry, something went wrong.
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks! I've missed the comment. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.