FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-151177: Fix race condition in `_testembed` by ZeroIntensity · Pull Request #151293 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-151177: Fix race condition in _testembed - #151293

Merged
encukou merged 1 commit into
python:mainfrom
ZeroIntensity:fix-testembed
Jun 11, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-151177: Fix race condition in _testembed#151293
encukou merged 1 commit into
python:mainfrom
ZeroIntensity:fix-testembed

Conversation

ZeroIntensity commented Jun 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The interpreter guard needs to be released after the flag has been set, not before. Otherwise, the main thread will be unblocked and can potentially read the done flag before the thread has a chance to set it.

ZeroIntensity added tests Tests in the Lib/test dir skip news needs backport to 3.15 bugs and security fixes labels Jun 11, 2026
bedevere-app Bot mentioned this pull request Jun 11, 2026
Closed
ZeroIntensity requested a review from encukou June 11, 2026 02:36

ZeroIntensity commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

!buildbot s390x

bedevere-bot commented Jun 11, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 891a74e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F151293%2Fmerge

The command will test the builders whose names match following regular expression: s390x

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x Fedora Stable Clang PR
  • s390x Fedora Rawhide PR
  • s390x Fedora Stable Refleaks PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x Fedora Rawhide NoGIL PR
  • s390x Fedora Stable Clang Installed PR
  • s390x RHEL8 Refleaks PR
  • s390x Fedora Stable LTO + PGO PR
  • s390x Fedora Stable LTO PR
  • s390x RHEL9 Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x RHEL9 PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x RHEL9 LTO + PGO PR
  • s390x Fedora Rawhide NoGIL refleaks PR
  • s390x RHEL9 LTO PR
  • s390x Fedora Rawhide Clang PR
  • s390x RHEL8 PR
  • s390x RHEL8 LTO PR
  • s390x Fedora Rawhide LTO PR
  • s390x Fedora Stable PR

encukou merged commit f9ffca3 into python:main Jun 11, 2026
81 checks passed

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151312 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 11, 2026
ZeroIntensity added a commit that referenced this pull request Jun 11, 2026
[3.15] gh-151177: Fix race condition in _testembed (GH-151293) (GH-…
491768d 
…151312)

gh-151177: Fix race condition in `_testembed` (GH-151293)
(cherry picked from commit f9ffca3)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity deleted the fix-testembed branch June 11, 2026 12:25
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
pythongh-151177: Fix race condition in _testembed (pythonGH-151293)
a406230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL