FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix Sphinx nitpick in unittest.mock.rst by cmaloney · Pull Request #151302 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix Sphinx nitpick in unittest.mock.rst - #151302

Merged
StanFromIreland merged 1 commit into
python:mainfrom
cmaloney:fix_unittest_mock_nit
Jun 11, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-101100: Fix Sphinx nitpick in unittest.mock.rst#151302
StanFromIreland merged 1 commit into
python:mainfrom
cmaloney:fix_unittest_mock_nit

Conversation

cmaloney commented Jun 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Removes from .nitignore. GH-124106 fixed most the warnings but left this one unfixed. GH-113163 fixed many of the dunders referring to the general definitions but this case refers to implementing a mock. Match what __eq__ and __ne__ did a few lines before to refer to an implementing instance.

pythongh-101100: Fix Sphinx nitpick in unittest.mock.rst
ef7c0b2 
Removes from `.nitignore`. pythonGH-124106 fixed most the warnings but left
this one unfixed. pythonGH-113163 fixed many of the dunders referring to the
general definitions but this case refers to implementing a mock. Match
what `__eq__` and `__ne__` did a few lines before to refer to an
implementing instance.
bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 11, 2026
github-project-automation Bot moved this to Todo in Docs PRs Jun 11, 2026

read-the-docs-community Bot commented Jun 11, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33088676 | 📁 Comparing ef7c0b2 against main (84630e2)

  🔍 Preview build  

1 file changed
± library/unittest.mock.html

StanFromIreland approved these changes Jun 11, 2026
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

StanFromIreland added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 11, 2026
StanFromIreland merged commit b18168c into python:main Jun 11, 2026
46 checks passed

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @cmaloney for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151355 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 11, 2026

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151356 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 11, 2026

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151357 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 11, 2026
github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 11, 2026
StanFromIreland pushed a commit that referenced this pull request Jun 11, 2026
[3.13] gh-101100: Fix Sphinx nitpick in unittest.mock.rst (GH-151302)
bba6886 
(cherry picked from commit b18168c)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
StanFromIreland pushed a commit that referenced this pull request Jun 11, 2026
[3.14] gh-101100: Fix Sphinx nitpick in unittest.mock.rst (GH-151302)…
41f2d6f 
… (#151356)

(cherry picked from commit b18168c)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
StanFromIreland pushed a commit that referenced this pull request Jun 11, 2026
[3.15] gh-101100: Fix Sphinx nitpick in unittest.mock.rst (GH-151302)…
fdf0132 
… (#151355)

(cherry picked from commit b18168c)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
cmaloney deleted the fix_unittest_mock_nit branch June 11, 2026 18:01
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
pythongh-101100: Fix Sphinx nitpick in unittest.mock.rst (python#15…
d2f87c0 
…1302)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL