[3.8] bpo-32912: Revert warnings for invalid escape sequences. - #15142
Merged
gpshead merged 3 commits intoAug 9, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals in 3.8. SyntaxWarning will be emitted in 3.9.
jdemeyer
reviewed
Aug 6, 2019
Comment thread
Doc/reference/lexical_analysis.rst
Outdated
rhettinger
approved these changes
Aug 8, 2019
and mention that SyntaxError will happen after SyntaxWarning. we're being non-specific on purpose here as we haven't worked out the plan to make this happen without causing end user pain yet. right now most code owners do not see the DeprecationWarning but when turned into a SyntaxWarning, _users_ of libraries see it more often than owners. So it is a negative experience all around.
gpshead
approved these changes
Aug 8, 2019
Copy link
Copy Markdown
Member
|
My only problem with this PR is only that it is being done on the 3.8 branch. We should revert this on the master (future 3.9) branch as well. We clearly aren't ready to commit to doing this in 3.9 either so lets redo this on top of that and apply the "needs backport to 3.8" label. |
Sorry, something went wrong.
CuriousLearner
approved these changes
Aug 9, 2019
CuriousLearner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I tend to agree with @gpshead on applying this to master and then backporting to 3.8
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
merged. I'll just reapply an equivalent to master. |
Sorry, something went wrong.
miss-islington
pushed a commit
that referenced
this pull request
Aug 10, 2019
DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals just as it did in 3.7. SyntaxWarning may be emitted in the future. But per mailing list discussion, we don't yet know when because we haven't settled on how to do so in a non-disruptive manner. (Applies 4c5b6ba to the master branch). (This is #15142 for master/3.9) https://bugs.python.org/issue32912 Automerge-Triggered-By: @gpshead
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…H-15195) DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals just as it did in 3.7. SyntaxWarning may be emitted in the future. But per mailing list discussion, we don't yet know when because we haven't settled on how to do so in a non-disruptive manner. (Applies 4c5b6ba to the master branch). (This is python#15142 for master/3.9) https://bugs.python.org/issue32912 Automerge-Triggered-By: @gpshead
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…H-15195) DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals just as it did in 3.7. SyntaxWarning may be emitted in the future. But per mailing list discussion, we don't yet know when because we haven't settled on how to do so in a non-disruptive manner. (Applies 4c5b6ba to the master branch). (This is python#15142 for master/3.9) https://bugs.python.org/issue32912 Automerge-Triggered-By: @gpshead
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…H-15195) DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals just as it did in 3.7. SyntaxWarning may be emitted in the future. But per mailing list discussion, we don't yet know when because we haven't settled on how to do so in a non-disruptive manner. (Applies 4c5b6ba to the master branch). (This is python#15142 for master/3.9) https://bugs.python.org/issue32912 Automerge-Triggered-By: @gpshead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeprecationWarning will continue to be emitted for invalid
escape sequences in string and bytes literals in 3.8.
SyntaxWarning will be emitted in 3.9.
https://bugs.python.org/issue32912