[3.15] gh-151422: Don't link libffi into _ctypes_test.so (GH-151423) - #151516
Merged
freakboy3742 merged 1 commit intoJun 15, 2026
Merged
[3.15] gh-151422: Don't link libffi into _ctypes_test.so (GH-151423)#151516freakboy3742 merged 1 commit into
freakboy3742 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
) _ctypes_test doesn't use libffi directly, and linking it into the module causes emscripten tests to fail. (cherry picked from commit 8646385) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
miss-islington
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
June 15, 2026 22:16
freakboy3742
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_ctypes_test doesn't use libffi directly, and linking it into the module
causes emscripten tests to fail.
(cherry picked from commit 8646385)
Co-authored-by: Hood Chatham roberthoodchatham@gmail.com