FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-151542: Use at least 2 MiB stack size, instead of 1 MiB by vstinner · Pull Request #151543 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-151542: Use at least 2 MiB stack size, instead of 1 MiB - #151543

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:stack_size_2mib
ConversationCommits (1)ChecksFiles changed
Closed

gh-151542: Use at least 2 MiB stack size, instead of 1 MiB#151543
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:stack_size_2mib

Conversation

vstinner commented Jun 16, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Python needs at least 2 MiB stack to run test_threading on Free Threading.

pythongh-151542: Use at least 2 MiB stack size, instead of 1 MiB
8c1a623 
Python needs at least 2 MiB stack to run test_threading on Free
Threading.
vstinner added the needs backport to 3.14 bugs and security fixes label Jun 16, 2026
vstinner added the needs backport to 3.15 bugs and security fixes label Jun 16, 2026
bedevere-app Bot mentioned this pull request Jun 16, 2026
Closed

kumaraditya303 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Is there any downside to bump it to 8MB which is default on glibc?

vstinner commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Tests / Sanitizers / TSan (free-threading) (pull_request): Failing after 23m

Ah, that's the unrelated test_ssl issue gh-150191:

WARNING: ThreadSanitizer: data race (pid=19679)
  Read of size 8 at 0x720800031f80 by thread T11:
    #0 memcmp <null> (python+0x10a64e) (BuildId: 41036444ba804d65aa7dcf36ed904a99f126bd28)
    #1 ASN1_STRING_cmp <null> (libcrypto.so.3+0xd5904) (BuildId: 79b8e7622d14cb55e5704008d40c02423919bfae)
...

vstinner commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Python needs at least 2 MiB stack to run test_threading on Free Threading.

I created issue gh-151546 for the root cause: _Py_Dealloc() mechanism (_Py_RecursionLimit_GetMargin()) to avoid stack overflow doesn't work properly on musl.

vstinner marked this pull request as draft June 16, 2026 15:29

vstinner commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

This change is more a workaround than a fix for the root issue. I mark this PR as a draft for now.

I wrote #151548 to fix the root issue.

vstinner commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

I merged #151548 fix instead. I close this PR.

vstinner closed this Jun 17, 2026
vstinner deleted the stack_size_2mib branch June 17, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
itamaro Awaiting requested review from itamaro itamaro is a code owner

Assignees

No one assigned

Labels

needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL