Repository navigation
gh-151678: Add tests for tkinter.Menu - #151685
Merged
serhiy-storchaka merged 1 commit intoJun 19, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
force-pushed
the
test-tkinter-menu-methods
branch
from
7b9a320 to
f9c55d8
Compare
June 19, 2026 00:08
Cover previously-untested Menu methods in MenuTest: adding, inserting and deleting items of every type, index resolution, invoking items, entry x/y positions, and post/unpost/tk_popup mapping. Also test per-entry configuration options and the errors raised for invalid indices, entry types, option names and option values. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
force-pushed
the
test-tkinter-menu-methods
branch
from
f9c55d8 to
4714219
Compare
June 19, 2026 08:08
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-151709 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-151710 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-151711 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 19, 2026
Cover previously-untested Menu methods in MenuTest: adding, inserting and deleting items of every type, index resolution, invoking items, entry x/y positions, and post/unpost/tk_popup mapping. Also test per-entry configuration options and the errors raised for invalid indices, entry types, option names and option values. (cherry picked from commit ef5c32a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 19, 2026
Cover previously-untested Menu methods in MenuTest: adding, inserting and deleting items of every type, index resolution, invoking items, entry x/y positions, and post/unpost/tk_popup mapping. Also test per-entry configuration options and the errors raised for invalid indices, entry types, option names and option values. (cherry picked from commit ef5c32a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 19, 2026
Cover previously-untested Menu methods in MenuTest: adding, inserting and deleting items of every type, index resolution, invoking items, entry x/y positions, and post/unpost/tk_popup mapping. Also test per-entry configuration options and the errors raised for invalid indices, entry types, option names and option values. (cherry picked from commit ef5c32a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pyctrl
pushed a commit
to pyctrl/cpython
that referenced
this pull request
Jul 5, 2026
Cover previously-untested Menu methods in MenuTest: adding, inserting and deleting items of every type, index resolution, invoking items, entry x/y positions, and post/unpost/tk_popup mapping. Also test per-entry configuration options and the errors raised for invalid indices, entry types, option names and option values. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover previously-untested Menu methods in MenuTest:
It also tests per-entry configuration options (accelerator, underline, state, colors, columnbreak, hidemargin, onvalue/offvalue, value, indicatoron) and the errors raised for invalid indices, entry types, option names and option values.