Repository navigation
gh-151744: Add curses.nofilter() - #151747
Merged
serhiy-storchaka merged 1 commit intoJun 19, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Wrap the ncurses nofilter() function, which undoes the effect of filter(). Without it there is no way to restore normal screen sizing after a curses.filter() call in the same process. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
June 19, 2026 17:20
serhiy-storchaka
enabled auto-merge (squash)
June 19, 2026 17:21
Copy link
Copy Markdown
Documentation build overview3 files changed ± library/curses.html ± whatsnew/3.16.html ± whatsnew/changelog.html |
Sorry, something went wrong.
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot wasm32-wasi 3.x (tier-2) has failed when building commit 2e5843e. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1046/builds/12130 Summary of the results of the build (if available): Click to see traceback logsremote: Enumerating objects: 22, done.
remote: Counting objects: 10% (1/10)
remote: Counting objects: 20% (2/10)
remote: Counting objects: 30% (3/10)
remote: Counting objects: 40% (4/10)
remote: Counting objects: 50% (5/10)
remote: Counting objects: 60% (6/10)
remote: Counting objects: 70% (7/10)
remote: Counting objects: 80% (8/10)
remote: Counting objects: 90% (9/10)
remote: Counting objects: 100% (10/10)
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 11% (1/9)
remote: Compressing objects: 22% (2/9)
remote: Compressing objects: 33% (3/9)
remote: Compressing objects: 44% (4/9)
remote: Compressing objects: 55% (5/9)
remote: Compressing objects: 66% (6/9)
remote: Compressing objects: 77% (7/9)
remote: Compressing objects: 88% (8/9)
remote: Compressing objects: 100% (9/9)
remote: Compressing objects: 100% (9/9), done.
remote: Total 22 (delta 1), reused 1 (delta 1), pack-reused 12 (from 1)
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '2e5843e13fcfd768a435d82e6182af403844432c'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 2e5843e13fc gh-151744: Add curses.nofilter() (GH-151747)
Switched to and reset branch 'main'
⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `Platforms/WASI/` directory instead (i.e. `python Platforms/WASI`)
⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `Platforms/WASI/` directory instead (i.e. `python Platforms/WASI`)
⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `Platforms/WASI/` directory instead (i.e. `python Platforms/WASI`)
|
Sorry, something went wrong.
pyctrl
pushed a commit
to pyctrl/cpython
that referenced
this pull request
Jul 5, 2026
Wrap the ncurses nofilter() function, which undoes the effect of filter(). Without it there is no way to restore normal screen sizing after a curses.filter() call in the same process. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curses module wraps filter() but not its inverse nofilter().
filter() puts curses into single-line mode — it forces LINES to 1 at the next initscr(). nofilter(), an ncurses extension, undoes that effect.
Without it, code (or a test) that calls curses.filter() has no way to restore normal screen sizing for a later initscr() in the same process.
This wraps nofilter() as curses.nofilter(), guarded by a configure check, alongside the existing curses.filter().