Repository navigation
gh-151824: Add copy() to ZipFile - #151825
Open
danny0838 wants to merge 2 commits into
Open
danny0838 wants to merge 2 commits into
danny0838 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Documentation build overview14 files changed · ± 14 modified ± Modified |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Nicely ping related reviewers in the previous PR: @gpshead, @merwok, @jaraco, @emmatyping, @AA-Turner. |
Sorry, something went wrong.
picnixz
reviewed
Jun 21, 2026
Comment thread
Doc/library/zipfile.rst
Copy link
Copy Markdown
|
This PR is stale because it has been open for 90 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the remove() and repack() introduced by #134627, add copy() for performant member copying in a ZIP file.
Moving a member can also be done as a combination of copy(), remove(), and repack() like:
which is required since the filename is stored within the member's local file entry and thus need a gross rewriting.