Repository navigation
[3.13] gh-150484: Fix mock_open __exit__ with contextlib.ExitStack (GH-151829) - #151861
Merged
serhiy-storchaka merged 1 commit intoJun 21, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ack (pythonGH-151829) mock_open's _exit_side_effect had a fixed 3-arg signature, but contextlib.ExitStack calls __exit__ with 4 args (self + 3 exc info). Use *args to accept any number of arguments. (cherry picked from commit 85fa295) Co-authored-by: Zang Peiyu <166481866+factnn@users.noreply.github.com>
Copy link
Copy Markdown
Documentation build overview464 files changed · ± 424 modified · - 40 deleted ± Modified
- Deleted |
Sorry, something went wrong.
factnn
added a commit
to factnn/cpython
that referenced
this pull request
Oct 21, 2026
…Stack mock_open().__exit__ only misbehaves on 3.13 and 3.14, where it was fixed directly by pythonGH-151829 and backported as pythonGH-151861. Only the regression test belongs on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mock_open's _exit_side_effect had a fixed 3-arg signature, but
contextlib.ExitStack calls exit with 4 args (self + 3 exc info).
Use *args to accept any number of arguments.
(cherry picked from commit 85fa295)
Co-authored-by: Zang Peiyu 166481866+factnn@users.noreply.github.com