gh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set - #151952
Merged
gpshead merged 3 commits intoJul 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…mpile, and test_inspect to neutralize PYTHONPYCACHEPREFIX
zangjiucheng
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
June 22, 2026 22:12
15 tasks
Copy link
Copy Markdown
Member
|
test_inspect fails on Windows. Example:
FAIL: test_details_option_with_aliased_target (test.test_inspect.test_inspect.TestModuleCLI.test_details_option_with_aliased_target)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\Lib\test\test_inspect\test_inspect.py", line 6676, in test_details_option_with_aliased_target
self.assertEqual(output_lines, expected_lines)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: ['Tar[116 chars], 'Cached: None', 'Line: 98', ''] != ['Tar[116 chars], 'Cached: __pycache__\\frozencpython-316.pyc', 'Line: 98', '']
First differing element 3:
'Cached: None'
'Cached: __pycache__\\frozencpython-316.pyc'
['Target: ntpath:join (looked up as "os:path.join")',
'Origin: frozen',
'Source: D:\\a\\cpython\\cpython\\Lib\\ntpath.py',
- 'Cached: None',
+ 'Cached: __pycache__\\frozencpython-316.pyc',
'Line: 98',
'']
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I will resolve this today :) |
Sorry, something went wrong.
…d_target
On Windows, os.path resolves to ntpath which is a frozen module
(origin='frozen', cached=None). Calling cache_from_source('frozen')
fabricates a nonsensical path that mismatches the subprocess output of
None. Guard the cache_from_source call on cached being non-None.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…es, fix NEWS.d with no test target
gpshead
approved these changes
Jul 1, 2026
gpshead
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nice test suite cleanup, thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @zangjiucheng for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @zangjiucheng and @gpshead, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 564c58c718bc3de9cf3d9bc20cdc06317411c1cd 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-152736 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @zangjiucheng and @gpshead, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 564c58c718bc3de9cf3d9bc20cdc06317411c1cd 3.13 |
Sorry, something went wrong.
gpshead
pushed a commit
that referenced
this pull request
Jul 1, 2026
…GH-151952) (#152736) gh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set (GH-151952) Fix tests in test_compileall, test_import, test_importlib, test_py_compile, and test_inspect to neutralize PYTHONPYCACHEPREFIX (cherry picked from commit 564c58c) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
Copy link
Copy Markdown
|
GH-152744 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
gpshead
added a commit
that referenced
this pull request
Jul 1, 2026
…GH-151952) (#152744) Fix tests in test_compileall, test_import, test_importlib, test_py_compile, and test_inspect to neutralize PYTHONPYCACHEPREFIX (cherry picked from commit 564c58c) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
gpshead
added a commit
that referenced
this pull request
Jul 1, 2026
…GH-151952) (GH-152744) (#152748) [3.14] gh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set (GH-151952) (GH-152744) Fix tests in test_compileall, test_import, test_importlib, test_py_compile, and test_inspect to neutralize PYTHONPYCACHEPREFIX (cherry picked from commit 564c58c) (cherry picked from commit 7087839) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
maurycy
added a commit
to maurycy/cpython
that referenced
this pull request
Jul 1, 2026
* main: (266 commits) pythongh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set (pythonGH-151952) pythongh-152728: IDLE - move 3 toplevel fix_xyz functions to idlelb.util (python#152729) pythongh-152711: Add pythoninfo-build command to Platforms/Android (python#152713) pythongh-152715: Add pythoninfo-build command to Platforms/Apple (python#152716) pythongh-152433: Windows: enable mmapmodule for UWP (python#152473) pythongh-152433: Windows: use GetFileSizeEx instead of GetFileSize for memory mapped files (python#152383) pythonGH-81881: Raise `SpecialFileError` for sockets and devices in `shutil.copyfile` (python#142693) pythongh-152502: Detect the curses mouse interface and is_* methods portably (pythonGH-152705) pythongh-145857: Replace `DELETE_GLOBAL` with `PUSH_NULL; STORE_GLOBAL` (pythonGH-146314) pythongh-145854: Replace `DELETE_NAME` with `PUSH_NULL; STORE_NAME` (pythonGH-146006) pythongh-152680: Detect container/VM in test.pythoninfo (python#152668) pythongh-152682: Fix NULL dereference on OOM in `symtable_visit_type_param_bound_or_default` (python#152684) pythongh-151881: Skip tk_inactive negativity check on Windows (pythonGH-152683) pythongh-152546: Refactor `mappingproxy.__new__` to use `PyDictProxy_New` (python#152547) pythongh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` (python#152478) pythongh-152635: Raise MemoryError when the lock allocation fails in `_interpchannels.create()` (python#152642) pythongh-151029: Fix `test_remote_exec_deleted_static_executable` on static installed builds (pythonGH-152653) pythongh-121249: Deprecate using F/D type codes in the struct module (python#152309) pythongh-152192: Fix JUMP_BACKWARD passing a truncated oparg to the jit tracer (pythonGH-152382) Don't require the `_test{internal}capi` modules in `test_monitoring.py` (python#152311) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_py_compile, and test_compileall assume the default __pycache__
bytecode layout and fail when the suite is run with PYTHONPYCACHEPREFIX set.
subprocess-based tests) where that assumption is made so tests are environment-independent.
(isolated mode), which ignores PYTHONPYCACHEPREFIX, so the expected cached
path must be computed with sys.pycache_prefix=None to match.