Repository navigation
gh-51067: Extract _read_local_file_header() as a module-level function - #152139
Merged
StanFromIreland merged 1 commit intoJun 25, 2026
Merged
StanFromIreland merged 1 commit into
StanFromIreland merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… function Move the duplicate logic for reading and validating local file headers from `ZipFile.open()` and multiple `_Repacker` methods into a single shared function. This establishes a single source of truth to ensure behavioral consistency and prevents redundant code.
StanFromIreland
approved these changes
Jun 25, 2026
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merged, thanks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the duplicate logic for reading and validating local file headers from ZipFile.open() and multiple _Repacker methods into a single shared function. This establishes a single source of truth to ensure behavioral consistency and prevents redundant code.