| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
On a Python built without --with-dtrace, test_dtrace runs exactly one function: test_filter_probe_rows_ignores_warnings (test.test_dtrace.BPFTraceOutputTests.test_filter_probe_rows_ignores_warnings) ... ok Hum, I'm not sure that it's worth it to run this single test on a Python built without --with-dtrace. Instead, I suggest running the check at the module top-level and remove the check from CheckDtraceProbes.setUpClass(). Something like: if not support.has_subprocess_support:
raise unittest.SkipTest("test module requires subprocess")
if not sysconfig.get_config_var('WITH_DTRACE'):
raise unittest.SkipTest(
"CPython must be configured with the --with-dtrace option."
)So the whole test is skipped: 0:00:00 load avg: 0.72 mem: 29.9 MiB [1/1] test_dtrace test_dtrace skipped -- CPython must be configured with the --with-dtrace option. 0:00:00 load avg: 0.72 mem: 31.0 MiB [1/1] test_dtrace skipped |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM. I prefer this simpler change!
Sorry, something went wrong.
|
Note: try to avoid git push --force, it makes reviews harder to follow. |
Sorry, something went wrong.
|
Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
|
GH-152300 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
|
GH-152301 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
|
GH-152302 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Skip functional test_dtrace cases when CPython was not configured with --with-dtrace.