FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-152235: Defer GC tracking in set.union and set.difference by corona10 · Pull Request #152290 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-152235: Defer GC tracking in set.union and set.difference - #152290

Merged
corona10 merged 2 commits into
python:mainfrom
corona10:gh-152235-union-diffrence
Jun 26, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-152235: Defer GC tracking in set.union and set.difference#152290
corona10 merged 2 commits into
python:mainfrom
corona10:gh-152235-union-diffrence

Conversation

corona10 commented Jun 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

corona10 requested a review from vstinner June 26, 2026 14:11
corona10 requested a review from rhettinger as a code owner June 26, 2026 14:11
corona10 added topic-free-threading needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 26, 2026
bedevere-app Bot mentioned this pull request Jun 26, 2026
Closed
corona10 force-pushed the gh-152235-union-diffrence branch from 3bbef7e to 18edd99 Compare June 26, 2026 14:11
vstinner approved these changes Jun 26, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Objects/setobject.c
PyObject *result;

result = set_copy_impl(so);
result = set_copy_untracked_lock_held(so);

vstinner Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You may rename set_copy_and_difference() to set_copy_and_difference_untracked(), and rename set_difference() to set_difference_untracked().

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-06-26-23-09-34.gh-issue-152235.ArozdF.rst Outdated
@@ -0,0 +1,2 @@
Defer GC tracking in :meth:`set.union`, :meth:`set.difference` and
:meth:`set.__sub__`. Patch by Donghee Na.

vstinner Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You may complete the Changelog entry of your previous PR.

vstinner Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, the Docs/Docs CI doesn't like set.__sub__ reference:

/home/runner/work/cpython/cpython/Doc/build/NEWS:854: WARNING: py:meth reference target not found: set.__sub__ [ref.meth]

corona10 enabled auto-merge (squash) June 26, 2026 16:46
corona10 merged commit 5a549e8 into python:main Jun 26, 2026
54 checks passed

miss-islington-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

Sorry, @corona10, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5a549e82b81378cb294904dab49cbee853bddd64 3.15

miss-islington-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

Sorry, @corona10, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5a549e82b81378cb294904dab49cbee853bddd64 3.13

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152312 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2026

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152316 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 26, 2026
corona10 deleted the gh-152235-union-diffrence branch June 26, 2026 17:25

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152319 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 26, 2026
corona10 added a commit that referenced this pull request Jun 26, 2026
[3.14] gh-152235: Defer GC tracking in set.union and set.difference (g…
4fa86ca 
…h-152290) (gh-152312)

gh-152235: Defer GC tracking in set.union and set.difference (gh-152290)
(cherry picked from commit 5a549e8)

Co-authored-by: Donghee Na <donghee.na@python.org>
corona10 added a commit that referenced this pull request Jun 26, 2026
[3.13] gh-152235: Defer GC tracking in set.union and set.difference (g…
668860b 
…h-152290) (gh-152319)

(cherry picked from commit 5a549e8)
corona10 added a commit that referenced this pull request Jun 26, 2026
[3.15] gh-152235: Defer GC tracking in set.union and set.difference (g…
073b658 
…h-152290) (gh-152316)

(cherry picked from commit 5a549e8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

corona10

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL