FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98894: Check readelf failures in test_dtrace by stratakis · Pull Request #152345 · python/cpython · GitHub

/ cpython Public

gh-98894: Check readelf failures in test_dtrace #152345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Jul 2, 2026
Conversation 8 Commits 2 Checks 60 Files changed
Merged

gh-98894: Check readelf failures in test_dtrace #152345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3555323
gh-98894: Check readelf failures in test_dtrace
stratakis Jun 26, 2026
3372f7c
Create a helper for readelf checking shared code
stratakis Jul 2, 2026
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
62 changes: 29 additions & 33 deletions Lib/test/test_dtrace.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,33 @@ def kill_process_group(proc):
proc.communicate() # Clean up


def run_readelf(cmd):
# Force the C locale to disable localization.
env = dict(os.environ, LC_ALL="C")
try:
proc = subprocess.Popen(
cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
text=True,
env=env,
)
except OSError:
raise unittest.SkipTest("Couldn't find readelf on the path")

with proc:
stdout, stderr = proc.communicate()

if proc.returncode:
raise AssertionError(
f"Command {' '.join(cmd)!r} failed "
f"with exit code {proc.returncode}: "
f"stdout={stdout!r} stderr={stderr!r}"
)

return stdout


class TraceBackend:
EXTENSION = None
COMMAND = None
Expand Down Expand Up @@ -408,28 +435,7 @@ def setUpClass(cls):

@staticmethod
def get_readelf_version():
try:
cmd = ["readelf", "--version"]
# Force the C locale to disable localization.
env = dict(os.environ, LC_ALL="C")
proc = subprocess.Popen(
cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
universal_newlines=True,
env=env,
)
with proc:
version, stderr = proc.communicate()

if proc.returncode:
raise Exception(
f"Command {' '.join(cmd)!r} failed "
f"with exit code {proc.returncode}: "
f"stdout={version!r} stderr={stderr!r}"
)
except OSError:
raise unittest.SkipTest("Couldn't find readelf on the path")
version = run_readelf(["readelf", "--version"])

# Regex to parse:
# 'GNU readelf (GNU Binutils) 2.40.0\n' -> 2.40
Expand Down Expand Up @@ -461,17 +467,7 @@ def get_readelf_output(self):
binary = libpython_path
break

command = ["readelf", "-n", binary]
# Force the C locale to disable localization.
env = dict(os.environ, LC_ALL="C")
stdout, _ = subprocess.Popen(
command,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
universal_newlines=True,
env=env,
).communicate()
return stdout
return run_readelf(["readelf", "-n", binary])

def test_check_probes(self):
readelf_output = self.get_readelf_output()
Expand Down
Loading
Back | FazBrowse Home | New Git URL