Repository navigation
gh-71880: Allow editing the last cell in curses.textpad.Textbox - #152363
Merged
serhiy-storchaka merged 2 commits intoJun 27, 2026
Merged
serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Textbox.edit() ignored typing in the lower-right cell of the window. It is now written with insch(), which fills the cell without moving the cursor out of the window (addch() there raises an error and scrolls a scrollable window). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-152364 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-152365 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-152366 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 27, 2026
GH-152363) (GH-152365) Textbox.edit() ignored typing in the lower-right cell of the window. It is now written with insch(), which fills the cell without moving the cursor out of the window (addch() there raises an error and scrolls a scrollable window). (cherry picked from commit 11b3943) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 27, 2026
GH-152363) (GH-152366) Textbox.edit() ignored typing in the lower-right cell of the window. It is now written with insch(), which fills the cell without moving the cursor out of the window (addch() there raises an error and scrolls a scrollable window). (cherry picked from commit 11b3943) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 27, 2026
GH-152363) (GH-152364) Textbox.edit() ignored typing in the lower-right cell of the window. It is now written with insch(), which fills the cell without moving the cursor out of the window (addch() there raises an error and scrolls a scrollable window). (cherry picked from commit 11b3943) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curses.textpad.Textbox.edit() ignored a character typed in the lower-right cell of the window: the cursor could be moved there, but typing did nothing.
Guards in do_command() and the insertion loop skipped that cell because writing it with addch() moves the cursor past the end of the window, which raises an error (and scrolls the window if scrolling is enabled).
The cell is now written with insch(), which fills it without moving the cursor, so it works regardless of scrollok. In insert mode the cell receives the shifted character.