FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-152434: Block --async-aware with --binary by lkollar · Pull Request #152444 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-152434: Block --async-aware with --binary - #152444

Merged
pablogsal merged 1 commit into
python:mainfrom
lkollar:tachyon/binary-async-aware
Jun 27, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-152434: Block --async-aware with --binary#152444
pablogsal merged 1 commit into
python:mainfrom
lkollar:tachyon/binary-async-aware

Conversation

lkollar commented Jun 27, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The binary writer does not currently handle AwaitedInfo samples and crashes when running in --async-aware mode.

Block --async-aware with --binary
9cd0a66 
The binary writer does not currently handle AwaitedInfo samples and
crashes when running in --async-aware mode.
lkollar requested a review from pablogsal as a code owner June 27, 2026 16:29
bedevere-app Bot mentioned this pull request Jun 27, 2026
Closed
pablogsal added needs backport to 3.15 bugs and security fixes skip news and removed awaiting merge labels Jun 27, 2026
pablogsal enabled auto-merge (squash) June 27, 2026 16:44

pablogsal commented Jun 27, 2026

Copy link
Copy Markdown
Member

Thanks @lkollar !

pablogsal merged commit 876c06c into python:main Jun 27, 2026
60 checks passed

miss-islington-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

Thanks @lkollar for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

GH-152446 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 27, 2026
pablogsal pushed a commit that referenced this pull request Jun 27, 2026
[3.15] gh-152434: Block --async-aware with --binary (GH-152444) (#152446
61bb57f 
)

gh-152434: Block --async-aware with --binary (GH-152444)

The binary writer does not currently handle AwaitedInfo samples and
crashes when running in --async-aware mode.
(cherry picked from commit 876c06c)

Co-authored-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL