Repository navigation
gh-152233: Make the curses cell API work without ncursesw - #152466
Merged
serhiy-storchaka merged 1 commit intoJun 28, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Back complexchar, complexstr and the cell read methods (in_wch, in_wchstr, in_wstr, getbkgrnd) with a chtype instead of a cchar_t when ncursesw is absent, so the same code works on both builds. A narrow build is limited to one character per cell, encodable as a single byte in the window's encoding (8-bit locales), with the color pair limited to the color_pair() range. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copy link
Copy Markdown
Documentation build overview3 files changed ± library/curses.html ± whatsnew/3.16.html ± whatsnew/changelog.html |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make complexchar, complexstr and the cell read methods in_wch, in_wchstr, in_wstr and getbkgrnd work whether or not Python was built against a wide-character (ncursesw) library, so the same code runs on both builds.
When ncursesw is absent a cell is backed by a chtype instead of a cchar_t: it holds a single character, encodable as one byte in the window's encoding (so only 8-bit locales are supported), with the color pair limited to the color_pair() range. get_wch, get_wstr, erasewchar, killwchar and wunctrl stay wide-only (they have no narrow counterpart with the same return type).
Tested on both a wide (-lncursesw) and a narrow (-lncurses) build of test_curses under en_US.UTF-8, en_US.ISO-8859-15 and uk_UA.KOI8-U.