FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-85320: Use UTF-8 for IDLE configuration and breakpoint files by serhiy-storchaka · Pull Request #152475 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-85320: Use UTF-8 for IDLE configuration and breakpoint files - #152475

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:idle-config-utf8
Jun 29, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-85320: Use UTF-8 for IDLE configuration and breakpoint files#152475
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:idle-config-utf8

Conversation

serhiy-storchaka commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

IDLE opened its configuration files (.idlerc/config-*.cfg) and the breakpoints file without an explicit encoding, so they used the locale encoding. Non-ASCII data — such as non-ASCII paths in the breakpoints file or help-source URLs in the config — could be corrupted, and the files were not portable between environments.

Read them as UTF-8 with errors='replace' and write them as UTF-8, matching the long-standing treatment of recent-files.lst.

Since UTF-8 mode is the default from 3.15 (PEP 686), this is mostly a no-op on current main except under -X utf8=0; the behavioral fix matters on the 3.13 and 3.14 backports, where the locale encoding is still used.

Reading with errors='replace' instead of the locale codec also means a config file written in a different encoding no longer raises UnicodeDecodeError and crashes IDLE on startup; it is decoded lossily instead. This also fixes gh-84615.

pythongh-85320: Use UTF-8 for IDLE configuration and breakpoint files
6c5ed4d 
They were read and written using the locale encoding, which could corrupt
non-ASCII paths and made them non-portable.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bedevere-app Bot mentioned this pull request Jun 28, 2026
Closed
serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 28, 2026

terryjreedy commented Jun 28, 2026

Copy link
Copy Markdown
Member

I intend to check later today that the change creates no problems on an existing Window installation with both config and breakpoint files.

terryjreedy approved these changes Jun 29, 2026
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My quick check of reading, editing, saving and using both files showed no problems.

Comment thread Lib/idlelib/News3.txt
Update Lib/idlelib/News3.txt
eb54eaf 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
serhiy-storchaka enabled auto-merge (squash) June 29, 2026 07:48
serhiy-storchaka merged commit f6e904e into python:main Jun 29, 2026
51 checks passed

miss-islington-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152555 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 29, 2026

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152556 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 29, 2026

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152557 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 29, 2026
serhiy-storchaka added a commit that referenced this pull request Jun 29, 2026
[3.13] gh-85320: Use UTF-8 for IDLE configuration and breakpoint files (
add35e2 
GH-152475) (GH-152557)

They were read and written using the locale encoding, which could corrupt
non-ASCII paths and made them non-portable.
(cherry picked from commit f6e904e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jun 29, 2026
[3.14] gh-85320: Use UTF-8 for IDLE configuration and breakpoint files (
f9c44ea 
GH-152475) (GH-152556)

They were read and written using the locale encoding, which could corrupt
non-ASCII paths and made them non-portable.
(cherry picked from commit f6e904e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jun 29, 2026
[3.15] gh-85320: Use UTF-8 for IDLE configuration and breakpoint files (
ac30e9b 
GH-152475) (GH-152555)

They were read and written using the locale encoding, which could corrupt
non-ASCII paths and made them non-portable.
(cherry picked from commit f6e904e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka deleted the idle-config-utf8 branch June 29, 2026 08:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IDLE should catch user config file UnicodeDecodeError

2 participants

Back | FazBrowse Home | New Git URL