FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-152359: Update numbers.rst to reference numeric-hash docs by tangyuan0821 · Pull Request #152549 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-152359: Update numbers.rst to reference numeric-hash docs - #152549

Merged
picnixz merged 4 commits into
python:mainfrom
tangyuan0821:152359
Jun 29, 2026
ConversationCommits (4)ChecksFiles changed
Merged

gh-152359: Update numbers.rst to reference numeric-hash docs#152549
picnixz merged 4 commits into
python:mainfrom
tangyuan0821:152359

Conversation

tangyuan0821 commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Remove the outdated Fraction.__hash__ example and link to numeric-hash docs.

bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jun 29, 2026
bedevere-app Bot mentioned this pull request Jun 29, 2026
Closed
github-project-automation Bot moved this to Todo in Docs PRs Jun 29, 2026
tangyuan0821 changed the title gh-152359: Update numbers module documentation gh-152359: Update numbers.rst to reference numeric-hash docs Jun 29, 2026
picnixz reviewed Jun 29, 2026
View reviewed changes
Comment thread Doc/library/numbers.rst Outdated
tangyuan0821 and others added 2 commits June 29, 2026 15:22
Update Doc/library/numbers.rst
7d47a51 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Revert "Update Doc/library/numbers.rst"
2f04704 
This reverts commit 7d47a51.
skirpichev reviewed Jun 29, 2026
View reviewed changes
Comment thread Doc/library/numbers.rst Outdated

read-the-docs-community Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33352309 | 📁 Comparing 3609e61 against main (2670cb0)

  🔍 Preview build  

4 files changed
± howto/mro.html
± library/hashlib.html
± library/numbers.html
± whatsnew/changelog.html

tangyuan0821 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@skirpichev @picnixz Both suggestions make sense to me. Could you two agree on which one to go with?

skirpichev commented Jun 29, 2026

Copy link
Copy Markdown
Member

Both suggestions make sense to me. Could you two agree on which one to go with?

Well, usually it's safer to prefer suggestion from core developer.

Looks ok for me too.

tangyuan0821 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Applied the suggestion, thanks both! PTAL.

picnixz commented Jun 29, 2026

Copy link
Copy Markdown
Member

My rationale is that the title of the linked section is "Hashing of numeric types" so I think it's explicit enough. And having the "also" after the "See" makes it a bit more optional (so you aren't interrupted in the reading flow too much)

picnixz added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 29, 2026

picnixz commented Jun 29, 2026

Copy link
Copy Markdown
Member

Just to be sure but the corresponding page is relevant even up to 3.13 right?

tangyuan0821 commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Just to be sure but the corresponding page is relevant even up to 3.13 right?确认一下，对应的页面在 3.13 版本中仍然适用，对吧？

Yes

picnixz merged commit 8ec36f1 into python:main Jun 29, 2026
40 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 29, 2026

miss-islington-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks @tangyuan0821 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152579 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 29, 2026

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152580 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 29, 2026

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152581 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 29, 2026
picnixz added a commit that referenced this pull request Jun 29, 2026
[3.15] gh-152359: Update numbers.rst to reference numeric-hash docs (G…
1507ea1 
…H-152549) (#152579)

gh-152359: Update numbers.rst to reference numeric-hash docs (GH-152549)
(cherry picked from commit 8ec36f1)

Co-authored-by: Paper Moon <tangyuan0821@email.cn>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull request Jun 29, 2026
[3.13] gh-152359: Update numbers.rst to reference numeric-hash docs (G…
3ef1368 
…H-152549) (#152581)

gh-152359: Update numbers.rst to reference numeric-hash docs (GH-152549)
(cherry picked from commit 8ec36f1)

Co-authored-by: Paper Moon <tangyuan0821@email.cn>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull request Jun 29, 2026
[3.14] gh-152359: Update numbers.rst to reference numeric-hash docs (G…
f287fe8 
…H-152549) (#152580)

gh-152359: Update numbers.rst to reference numeric-hash docs (GH-152549)
(cherry picked from commit 8ec36f1)

Co-authored-by: Paper Moon <tangyuan0821@email.cn>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
tangyuan0821 deleted the 152359 branch June 29, 2026 13:15
skirpichev removed their request for review July 5, 2026 02:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skirpichev skirpichev left review comments
picnixz picnixz approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL