FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-152563, test_math: Enable fma test on musl 1.2.6 by weixlu · Pull Request #152564 · python/cpython · GitHub

/ cpython Public

gh-152563, test_math: Enable fma test on musl 1.2.6 - #152564

Merged
vstinner merged 1 commit into
python:mainfrom
weixlu:fma
Aug 13, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-152563, test_math: Enable fma test on musl 1.2.6#152564
vstinner merged 1 commit into
python:mainfrom
weixlu:fma

Conversation

weixlu commented Jun 29, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Proposal:

#131313 fix many tests on Alpine Linux (musl C library). About test_fma_zero_result, it says

    # gh-131032: musl is fixed but the fix is not yet released; when the fixed
    # version is known change this to:
    #   or support.linked_to_musl() < (1, <m>, <p>)

And now musl 1.2.6 is available, and I have verified that the test can pass. So let's enable it.

  • docker image: alpine:edge
  • musl version: 1.2.6-r2
  • test result: pass

I also test the older version

  • docker image: alpine:3.21
  • musl version: 1.2.5-r11
  • test result: skipped

bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 29, 2026

This comment was marked as outdated.

Sign in to view
bedevere-app Bot mentioned this pull request Jun 29, 2026
Closed

This comment was marked as duplicate.

Sign in to view
StanFromIreland requested review from bitdancer and vstinner and removed request for vstinner June 29, 2026 09:34

vstinner commented Jun 29, 2026

Copy link
Copy Markdown
Member

image: alpine:edge
musl version: 1.2.6-r2
test result: pass

I just tested podman run --rm --interactive --tty alpine:edge: I still get musl 1.2.5.

~ # apk info musl
(...)
musl-1.2.5-r21 description:
the musl c library (libc) implementation

musl-1.2.5-r21 webpage:
https://musl.libc.org/

musl-1.2.5-r21 installed size:
650 KiB

I would prefer to wait until musl 1.2.6 final is released and available in Alpine Linux.

vstinner changed the title gh-152563: Enable fma test on Alpine Linux (musl C library) gh-152563, test_math: Enable fma test on musl 1.2.6 Jun 29, 2026

weixlu commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@vstinner Thanks for the review. Yes, I just double-checked and alpine:edge still defaults to musl-1.2.5. I previously ran apk add --no-cache musl-dev, that's why I got 1.2.6-r2.

I would prefer to wait until musl 1.2.6 final is released and available in Alpine Linux.

No problem, let's wait until 1.2.6 is officially included in the default version.

vstinner commented Aug 10, 2026

Copy link
Copy Markdown
Member

https://musl.libc.org/releases.html tells me that musl 1.2.6 was released in March 20, 2026.

No problem, let's wait until 1.2.6 is officially included in the default version.

@weixlu: Hi. Can you check if it's the case now?

weixlu commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@vstinner Ah yes, thanks for reminder. I have verified that musl 1.2.6 is now officially included

$ docker run --rm alpine:edge apk info musl

musl-1.2.6-r2 description:
the musl c library (libc) implementation

musl-1.2.6-r2 webpage:
https://musl.libc.org/

musl-1.2.6-r2 installed size:
706 KiB

Also I've run test_math and it looks good. So I think this PR is ready to go

vstinner approved these changes Aug 11, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I confirm that all FMA tests of test_math pass on the latest Alpine Linux with musl-1.2.6-r2.

~/cpython # apk info musl
musl-1.2.6-r2 description:
the musl c library (libc) implementation

musl-1.2.6-r2 webpage:
https://musl.libc.org/

musl-1.2.6-r2 installed size:
654 KiB

~/cpython # ./python
Python 3.16.0a0 (heads/main:fcfa919, Aug 11 2026, 13:30:35) [GCC 15.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from test import support
>>> support.linked_to_musl()
(1, 2, 6)

vstinner commented Aug 11, 2026

Copy link
Copy Markdown
Member

cc @zware @bitdancer

vstinner merged commit 5ea3935 into python:main Aug 13, 2026
54 checks passed
vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 13, 2026

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @weixlu for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @weixlu for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @weixlu for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155753 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 13, 2026

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155754 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 13, 2026

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155755 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 13, 2026

vstinner commented Aug 13, 2026

Copy link
Copy Markdown
Member

Merged, thanks for the change.

vstinner pushed a commit that referenced this pull request Aug 13, 2026
[3.13] gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564) (
8e85d73 
#155753)

gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564)
(cherry picked from commit 5ea3935)

Co-authored-by: Xiaowei Lu <weixlu420302@gmail.com>
vstinner pushed a commit that referenced this pull request Aug 13, 2026
[3.14] gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564) (
4e9ec0a 
#155754)

gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564)
(cherry picked from commit 5ea3935)

Co-authored-by: Xiaowei Lu <weixlu420302@gmail.com>
hugovk pushed a commit that referenced this pull request Aug 14, 2026
[3.15] gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564) (
7533d8a 
#155755)

gh-152563, test_math: Enable fma test on musl 1.2.6 (GH-152564)
(cherry picked from commit 5ea3935)

Co-authored-by: Xiaowei Lu <weixlu420302@gmail.com>
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
pythongh-152563, test_math: Enable fma test on musl 1.2.6 (python#152564
0eee29c 
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
bitdancer Awaiting requested review from bitdancer

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL